Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Fix L0_model_control_stress_vllm #79

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

yinggeh
Copy link
Contributor

@yinggeh yinggeh commented Dec 21, 2024

What does the PR do?

  • asyncio.get_event_loop() was deprecated in Python 3.12.
  • Initialize gRPC client inside the async loop.

More details in the Jira ticket.

Checklist

  • PR title reflects the change and is of format <commit_type>: <Title>
  • Changes are described in the pull request.
  • Related issues are referenced.
  • Populated github labels field
  • Added test plan and verified test passes.
  • Verified that the PR passes existing CI.
  • Verified copyright is correct on all changed files.
  • Added succinct git squash message before merging ref.
  • All template sections are filled out.
  • Optional: Additional screenshots for behavior/output changes with before/after.

Commit Type:

Check the conventional commit type
box here and add the label to the github PR.

  • ci

Related PRs:

Where should the reviewer start?

Test plan:

L0_model_control_stress_valgrind_massif_vllm--base
L0_model_control_stress_valgrind_vllm--base
L0_model_control_stress_vllm--base

  • CI Pipeline ID:
    21756139

Caveats:

Background

Pipeline job failures

Related Issues: (use one of the action keywords Closes / Fixes / Resolves / Relates to)

  • closes GitHub issue: #xxx

@yinggeh yinggeh added the bug Something isn't working label Dec 21, 2024
@yinggeh yinggeh self-assigned this Dec 21, 2024
@yinggeh yinggeh changed the title Fix L0_model_control_stress_vllm ci: Fix L0_model_control_stress_vllm Dec 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant