Enable loc info when printing .ttir .ttgir #2736
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: in triton.cc, enable_debug on PM will make sure debugging info is dumped when MLIR_ENABLE_DUMP is on. But for printing .ttir .ttgir, we are using the default OpPrintingFlags for Operation::print: const OpPrintingFlags &flags = std::nullopt With this patch, we pass in OpPrintingFlags with debug info enabled. Since the generation of debug info is controlled via env var: TRITON_DISABLE_LINE_INFO, it should be okay to print loc info as long as it exists. Test Plan: Reviewers: Subscribers: Tasks: Tags:
|
Thank you for the patch! LGTM |
jlebar
approved these changes
Nov 30, 2023
feihugis
pushed a commit
to feihugis/triton
that referenced
this pull request
Feb 13, 2024
Summary: in triton.cc, enable_debug on PM will make sure debugging info is dumped when MLIR_ENABLE_DUMP is on. But for printing .ttir .ttgir, we are using the default OpPrintingFlags for Operation::print: const OpPrintingFlags &flags = std::nullopt With this patch, we pass in OpPrintingFlags with debug info enabled. Since the generation of debug info is controlled via env var: TRITON_DISABLE_LINE_INFO, it should be okay to print loc info as long as it exists. Co-authored-by: Manman Ren <mren@meta.com>
shunting314
pushed a commit
to shunting314/triton
that referenced
this pull request
Mar 14, 2024
Summary: in triton.cc, enable_debug on PM will make sure debugging info is dumped when MLIR_ENABLE_DUMP is on. But for printing .ttir .ttgir, we are using the default OpPrintingFlags for Operation::print: const OpPrintingFlags &flags = std::nullopt With this patch, we pass in OpPrintingFlags with debug info enabled. Since the generation of debug info is controlled via env var: TRITON_DISABLE_LINE_INFO, it should be okay to print loc info as long as it exists. Co-authored-by: Manman Ren <mren@meta.com>
shunting314
pushed a commit
to shunting314/triton
that referenced
this pull request
Mar 14, 2024
Summary: in triton.cc, enable_debug on PM will make sure debugging info is dumped when MLIR_ENABLE_DUMP is on. But for printing .ttir .ttgir, we are using the default OpPrintingFlags for Operation::print: const OpPrintingFlags &flags = std::nullopt With this patch, we pass in OpPrintingFlags with debug info enabled. Since the generation of debug info is controlled via env var: TRITON_DISABLE_LINE_INFO, it should be okay to print loc info as long as it exists. Co-authored-by: Manman Ren <mren@meta.com>
shunting314
pushed a commit
to shunting314/triton
that referenced
this pull request
Mar 19, 2024
Summary: in triton.cc, enable_debug on PM will make sure debugging info is dumped when MLIR_ENABLE_DUMP is on. But for printing .ttir .ttgir, we are using the default OpPrintingFlags for Operation::print: const OpPrintingFlags &flags = std::nullopt With this patch, we pass in OpPrintingFlags with debug info enabled. Since the generation of debug info is controlled via env var: TRITON_DISABLE_LINE_INFO, it should be okay to print loc info as long as it exists. Co-authored-by: Manman Ren <mren@meta.com>
ptillet
added a commit
that referenced
this pull request
Mar 19, 2024
Cherry pick a few PRs to make PyTorch 2.3 work with Triton 2.2.x . Also this makes sure some python bindings needed by user defined triton kernel exists in the triton branch. --------- Co-authored-by: Philippe Tillet <phil@openai.com> Co-authored-by: Manman Ren <manman.ren@gmail.com> Co-authored-by: Manman Ren <mren@meta.com>
ptillet
added a commit
that referenced
this pull request
Apr 1, 2024
Cherry pick a few PRs to make PyTorch 2.3 work with Triton 2.2.x . Also this makes sure some python bindings needed by user defined triton kernel exists in the triton branch. --------- Co-authored-by: Philippe Tillet <phil@openai.com> Co-authored-by: Manman Ren <manman.ren@gmail.com> Co-authored-by: Manman Ren <mren@meta.com>
binarman
pushed a commit
to binarman/triton
that referenced
this pull request
Apr 2, 2024
Summary: in triton.cc, enable_debug on PM will make sure debugging info is dumped when MLIR_ENABLE_DUMP is on. But for printing .ttir .ttgir, we are using the default OpPrintingFlags for Operation::print: const OpPrintingFlags &flags = std::nullopt With this patch, we pass in OpPrintingFlags with debug info enabled. Since the generation of debug info is controlled via env var: TRITON_DISABLE_LINE_INFO, it should be okay to print loc info as long as it exists. Co-authored-by: Manman Ren <mren@meta.com>
ptillet
added a commit
that referenced
this pull request
Apr 3, 2024
Cherry pick a few PRs to make PyTorch 2.3 work with Triton 2.2.x . Also this makes sure some python bindings needed by user defined triton kernel exists in the triton branch. --------- Co-authored-by: Philippe Tillet <phil@openai.com> Co-authored-by: Manman Ren <manman.ren@gmail.com> Co-authored-by: Manman Ren <mren@meta.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: in triton.cc, enable_debug on PM will make sure debugging info is dumped when MLIR_ENABLE_DUMP is on. But for printing .ttir .ttgir, we are using the default OpPrintingFlags for Operation::print: const OpPrintingFlags &flags = std::nullopt
With this patch, we pass in OpPrintingFlags with debug info enabled.
Since the generation of debug info is controlled via env var: TRITON_DISABLE_LINE_INFO, it should be okay to print loc info as long as it exists.