[BUILD] update for windows #2757
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
--- LLVM.old/include/llvm/Config/llvm-config.h 2023-11-30 16:26:37.000000000 +0900
+++ LLVM/include/llvm/Config/llvm-config.h 2023-12-09 03:18:38.000000000 +0900
@@ -193,7 +193,7 @@
#define LLVM_UNREACHABLE_OPTIMIZE 1
/* Define to 1 if you have the DIA SDK installed, and to 0 if you don't. */
-#define LLVM_ENABLE_DIA_SDK 1
+#define LLVM_ENABLE_DIA_SDK 0
/* Define if plugins enabled */
/* #undef LLVM_ENABLE_PLUGINS */
--- LLVM.old/lib/cmake/llvm/LLVMConfig.cmake 2023-11-30 16:26:56.000000000 +0900
+++ LLVM/lib/cmake/llvm/LLVMConfig.cmake 2023-12-09 03:18:54.000000000 +0900
@@ -204,7 +204,7 @@
set(LLVM_WITH_Z3 )
-set(LLVM_ENABLE_DIA_SDK ON)
+set(LLVM_ENABLE_DIA_SDK OFF)
set(LLVM_NATIVE_ARCH X86)
--- LLVM.old/lib/cmake/llvm/LLVMExports.cmake 2023-11-30 16:27:15.000000000 +0900
+++ LLVM/lib/cmake/llvm/LLVMExports.cmake 2023-12-09 03:19:10.000000000 +0900
@@ -471,7 +471,7 @@
add_library(LLVMDebugInfoPDB STATIC IMPORTED)
set_target_properties(LLVMDebugInfoPDB PROPERTIES
- INTERFACE_LINK_LIBRARIES "C:/Program Files/Microsoft Visual Studio/2022/Enterprise/DIA SDK/lib/amd64/diaguids.lib;LLVMBinaryFormat;LLVMObject;LLVMSupport;LLVMDebugInfoCodeView;LLVMDebugInfoMSF"
+ INTERFACE_LINK_LIBRARIES "LLVMBinaryFormat;LLVMObject;LLVMSupport;LLVMDebugInfoCodeView;LLVMDebugInfoMSF"
)
# Create imported target LLVMSymbolize |
* fix deprecation warning * use bash shell to fix error
* build "mlir" only * disable LLVM_ENABLE_DIA_SDK
wkpark
force-pushed
the
fix-llvm-build
branch
from
b5e9afb to
9fbd252
Compare
|
rebased, enable windows llvm build again. |
|
ping @gflegar |
biship
referenced
this pull request
in oobabooga/text-generation-webui
Feb 20, 2024
ThomasRaoux
pushed a commit
that referenced
this pull request
Oct 18, 2024
from #2757 * fix deprecation warning * use bash shell to fix `az storage ...` console error. * `-DLLVM_ENABLE_DIA_SDK=OFF` added to fix `DIA_SDK` dependency - `"ninja: error: 'C:/Program Files/Microsoft Visual Studio/2022/Enterprise/DIA SDK/lib/amd64/diaguids.lib', needed by 'D:/src/triton/python/build/lib.win-amd64-cpython-310/triton/_C/libtriton.pyd', missing and no known rule to make it"`. the latest windows llvm build is available at https://github.com/wkpark/triton/releases/tag/llvm-82f5acfb-windows It would be nice to have default llvm;mlir compiler on the official trion build system for someone who trying to develop solve some windows related issue even if windows is not officially supported. p.s.: and I'd like to thank all triton developers for their hard work!
chsigg
pushed a commit
to openxla/triton
that referenced
this pull request
Nov 4, 2024
from triton-lang#2757 * fix deprecation warning * use bash shell to fix `az storage ...` console error. * `-DLLVM_ENABLE_DIA_SDK=OFF` added to fix `DIA_SDK` dependency - `"ninja: error: 'C:/Program Files/Microsoft Visual Studio/2022/Enterprise/DIA SDK/lib/amd64/diaguids.lib', needed by 'D:/src/triton/python/build/lib.win-amd64-cpython-310/triton/_C/libtriton.pyd', missing and no known rule to make it"`. the latest windows llvm build is available at https://github.com/wkpark/triton/releases/tag/llvm-82f5acfb-windows It would be nice to have default llvm;mlir compiler on the official trion build system for someone who trying to develop solve some windows related issue even if windows is not officially supported. p.s.: and I'd like to thank all triton developers for their hard work!
chsigg
pushed a commit
that referenced
this pull request
Nov 5, 2024
from #2757 * fix deprecation warning * use bash shell to fix `az storage ...` console error. * `-DLLVM_ENABLE_DIA_SDK=OFF` added to fix `DIA_SDK` dependency - `"ninja: error: 'C:/Program Files/Microsoft Visual Studio/2022/Enterprise/DIA SDK/lib/amd64/diaguids.lib', needed by 'D:/src/triton/python/build/lib.win-amd64-cpython-310/triton/_C/libtriton.pyd', missing and no known rule to make it"`. the latest windows llvm build is available at https://github.com/wkpark/triton/releases/tag/llvm-82f5acfb-windows It would be nice to have default llvm;mlir compiler on the official trion build system for someone who trying to develop solve some windows related issue even if windows is not officially supported. p.s.: and I'd like to thank all triton developers for their hard work!
chsigg
pushed a commit
that referenced
this pull request
Nov 7, 2024
from #2757 * fix deprecation warning * use bash shell to fix `az storage ...` console error. * `-DLLVM_ENABLE_DIA_SDK=OFF` added to fix `DIA_SDK` dependency - `"ninja: error: 'C:/Program Files/Microsoft Visual Studio/2022/Enterprise/DIA SDK/lib/amd64/diaguids.lib', needed by 'D:/src/triton/python/build/lib.win-amd64-cpython-310/triton/_C/libtriton.pyd', missing and no known rule to make it"`. the latest windows llvm build is available at https://github.com/wkpark/triton/releases/tag/llvm-82f5acfb-windows It would be nice to have default llvm;mlir compiler on the official trion build system for someone who trying to develop solve some windows related issue even if windows is not officially supported. p.s.: and I'd like to thank all triton developers for their hard work!
vwbaker
pushed a commit
to openxla/triton
that referenced
this pull request
Nov 11, 2024
from triton-lang#2757 * fix deprecation warning * use bash shell to fix `az storage ...` console error. * `-DLLVM_ENABLE_DIA_SDK=OFF` added to fix `DIA_SDK` dependency - `"ninja: error: 'C:/Program Files/Microsoft Visual Studio/2022/Enterprise/DIA SDK/lib/amd64/diaguids.lib', needed by 'D:/src/triton/python/build/lib.win-amd64-cpython-310/triton/_C/libtriton.pyd', missing and no known rule to make it"`. the latest windows llvm build is available at https://github.com/wkpark/triton/releases/tag/llvm-82f5acfb-windows It would be nice to have default llvm;mlir compiler on the official trion build system for someone who trying to develop solve some windows related issue even if windows is not officially supported. p.s.: and I'd like to thank all triton developers for their hard work!
gflegar
pushed a commit
to openxla/triton
that referenced
this pull request
Dec 4, 2024
from triton-lang#2757 * fix deprecation warning * use bash shell to fix `az storage ...` console error. * `-DLLVM_ENABLE_DIA_SDK=OFF` added to fix `DIA_SDK` dependency - `"ninja: error: 'C:/Program Files/Microsoft Visual Studio/2022/Enterprise/DIA SDK/lib/amd64/diaguids.lib', needed by 'D:/src/triton/python/build/lib.win-amd64-cpython-310/triton/_C/libtriton.pyd', missing and no known rule to make it"`. the latest windows llvm build is available at https://github.com/wkpark/triton/releases/tag/llvm-82f5acfb-windows It would be nice to have default llvm;mlir compiler on the official trion build system for someone who trying to develop solve some windows related issue even if windows is not officially supported. p.s.: and I'd like to thank all triton developers for their hard work!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(please see https://github.com/openai/triton/actions/runs/7086790619 )
latest windows llvm build is available at https://github.com/wkpark/triton/actions/runs/7517218687