Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CLEANUP] Fix typos across the project #2876

Merged
merged 1 commit into from
Jan 5, 2024
Merged

Conversation

Wheest
Copy link
Contributor

@Wheest Wheest commented Jan 4, 2024

Feel free to close this PR and add the fixes in a more substantial commit.

This PR is just to highlight the typos.

@Wheest Wheest requested a review from ptillet as a code owner January 4, 2024 17:32
@Jokeren
Copy link
Contributor

Jokeren commented Jan 4, 2024

I'd suggest using something like codespell to check and fix all typos in a single PR

I was conservative in my correction criteria:
- `codespell` provided suggestions, but I used my own discretion
- I ignored anything in the third-party directory
- Corrections were only on comments and docs, no code (even if a variable name was clearly a typo). Exceptions to this
  - An error message string in AxisInfo.cpp:995
  - An error message string in hip.c:15
  - An error message sting in WSPipeline.cpp
  - Docstrings in tablegen files (still documentation, but is compiled)
@Wheest
Copy link
Contributor Author

Wheest commented Jan 4, 2024

Thanks!

I've done this, as I've been looking for an excuse to dive deeper into the codebase.

This PR should now be slightly more useful, as it corrects dozens of spelling errors, rather than just a couple. I squashed all my commits into a single one.

I was conservative in my correction criteria:

  • codespell provided suggestions, but I used my own discretion when applying them
  • I ignored anything in the third-party directory
  • Corrections were only on comments and docs, no code (even if a variable name was clearly a typo). Exceptions to this include:
    • An error message string in AxisInfo.cpp:995
    • An error message string in hip.c:15
    • An error message string in WSPipeline.cpp
    • Docstrings in tablegen files (still documentation, but is compiled)

I'm happy to expand this PR to include additional "quality of life" improvements that the team hasn't prioritized.

@Jokeren
Copy link
Contributor

Jokeren commented Jan 5, 2024

What're "quality of life" improvements?

Copy link
Collaborator

@ThomasRaoux ThomasRaoux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is a nice cleanup in itself

@ThomasRaoux ThomasRaoux changed the title [TUTORIALS] Fixed typos in Matrix Multiplication tutorial [CLEANUP] Fix typos across the project Jan 5, 2024
@Wheest
Copy link
Contributor Author

Wheest commented Jan 5, 2024

Thank you both!

@Jokeren, by QoL improvements, I mean things like:

  • Code Refactoring: any known places were Foo is implemented in a few ways, which could be unified, or a given Foo is overcomplicated?
  • CI/CD improvements: it seems like clang-format etc is already set up, but maybe support for additional targets, or updating build dependencies needs to be done?
  • Testing: tests seems to be pretty extensive, but perhaps there's some known edge cases that could be added (e.g., in TVM I fixed support for conv2d asymmetric padding & dilation).

Essentially anything that's suitable for a new contributor. I'll also look under the "help wanted" issue label.

@ThomasRaoux ThomasRaoux merged commit 53d8681 into triton-lang:main Jan 5, 2024
4 checks passed
binarman pushed a commit to binarman/triton that referenced this pull request Apr 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants