-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CLEANUP] Fix typos across the project #2876
Conversation
I'd suggest using something like |
I was conservative in my correction criteria: - `codespell` provided suggestions, but I used my own discretion - I ignored anything in the third-party directory - Corrections were only on comments and docs, no code (even if a variable name was clearly a typo). Exceptions to this - An error message string in AxisInfo.cpp:995 - An error message string in hip.c:15 - An error message sting in WSPipeline.cpp - Docstrings in tablegen files (still documentation, but is compiled)
Thanks! I've done this, as I've been looking for an excuse to dive deeper into the codebase. This PR should now be slightly more useful, as it corrects dozens of spelling errors, rather than just a couple. I squashed all my commits into a single one. I was conservative in my correction criteria:
I'm happy to expand this PR to include additional "quality of life" improvements that the team hasn't prioritized. |
What're "quality of life" improvements? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is a nice cleanup in itself
Thank you both! @Jokeren, by QoL improvements, I mean things like:
Essentially anything that's suitable for a new contributor. I'll also look under the "help wanted" issue label. |
Feel free to close this PR and add the fixes in a more substantial commit.
This PR is just to highlight the typos.