Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BACKEND] Update LLVM version to https://github.com/llvm/llvm-project/commit/1115dee248e68a155001ac3712a189299d104863 #4537

Merged
merged 16 commits into from
Aug 30, 2024
Merged

[BACKEND] Update LLVM version to https://github.com/llvm/llvm-project/commit/1115dee248e68a155001ac3712a189299d104863 #4537

merged 16 commits into from
Aug 30, 2024

Conversation

khasanovaa
Copy link
Contributor

@khasanovaa khasanovaa commented Aug 19, 2024 •
edited
Loading

  1. Updated llvm version up to 1115dee248e68a155001ac3712a189299d104863
  2. Included fixes that are required to the codebase to correspond the new version
  3. Fixed naming and version of gcc package

vwbaker and others added 6 commits August 19, 2024 14:10
@vwbaker
Copy link
Collaborator

vwbaker commented Aug 21, 2024 •
edited
Loading

There seems to be a bug in the llvm build CI at the moment where it can't find one of the deb files it's using: https://github.com/triton-lang/triton/actions/runs/10453943282/job/29066198718

Processing triggers for libc-bin (2.31-0ubuntu9.16) ...
--2024-08-21 15:52:06-- http://ftp.de.debian.org/debian/pool/main/g/gcc-defaults/gcc-aarch64-linux-gnu_13.2.0-7_amd64.deb
Resolving ftp.de.debian.org (ftp.de.debian.org)... 141.76.2.4
Connecting to ftp.de.debian.org (ftp.de.debian.org)|141.76.2.4|:80... connected.
HTTP request sent, awaiting response... 404 Not Found
2024-08-21 15:52:07 ERROR 404: Not Found.

Looking at http://ftp.de.debian.org/debian/pool/main/g/gcc-defaults/, it indeed seems to have omitted 13 altogether. It looks like triton hasn't updated that path in at least 6 months (

triton/.github/workflows/llvm-build.yml

Line 162 in 1c14382

wget http://ftp.de.debian.org/debian/pool/main/g/gcc-defaults/gcc-aarch64-linux-gnu_13.2.0-7_amd64.deb
) so perhaps we just need to switch to a different version.

@ThomasRaoux
Copy link
Collaborator

There seems to be a bug in the llvm build CI at the moment where it can't find one of the deb files it's using: https://github.com/triton-lang/triton/actions/runs/10453943282/job/29066198718

Processing triggers for libc-bin (2.31-0ubuntu9.16) ... --2024-08-21 15:52:06-- http://ftp.de.debian.org/debian/pool/main/g/gcc-defaults/gcc-aarch64-linux-gnu_13.2.0-7_amd64.deb Resolving ftp.de.debian.org (ftp.de.debian.org)... 141.76.2.4 Connecting to ftp.de.debian.org (ftp.de.debian.org)|141.76.2.4|:80... connected. HTTP request sent, awaiting response... 404 Not Found 2024-08-21 15:52:07 ERROR 404: Not Found.

Looking at http://ftp.de.debian.org/debian/pool/main/g/gcc-defaults/, it indeed seems to have omitted 13 altogether. It looks like triton hasn't updated that path in at least 6 months (

triton/.github/workflows/llvm-build.yml

Line 162 in 1c14382

wget http://ftp.de.debian.org/debian/pool/main/g/gcc-defaults/gcc-aarch64-linux-gnu_13.2.0-7_amd64.deb

) so perhaps we just need to switch to a different version.

yeah not sure why this disappeared but updating should be fine

@vwbaker
Copy link
Collaborator

vwbaker commented Aug 22, 2024

We updated gcc but I think the next issue has to be fixed manually by openai, seems to be an issue with the azure login, I've gotten it 3x now:

Run azure/login@v2
Running Azure CLI Login.
/usr/bin/az cloud set -n azurecloud
Done setting cloud: "azurecloud"
Federated token details:
 issuer - https://token.actions.githubusercontent.com
 subject claim - repo:triton-lang/triton:ref:refs/heads/llvm-head
Attempting Azure CLI login by using OIDC...
Error: AADSTS700213: No matching federated identity record found for presented assertion subject 'repo:triton-lang/triton:ref:refs/heads/llvm-head'. Please note that the matching is done using a case-sensitive comparison. Check your federated identity credential Subject, Audience and Issuer against the presented assertion. https://learn.microsoft.com/entra/workload-id/workload-identity-federation Trace ID: 8c0fdcd8-f884-4e74-b06c-5f55cd206b00 Correlation ID: 1c0c3c7f-cb5c-4753-affc-10e529f19db9 Timestamp: 2024-08-22 09:28:07Z
Interactive authentication is needed. Please run:
az login

Error: Login failed with Error: The process '/usr/bin/az' failed with exit code 1. Double check if the 'auth-type' is correct. Refer to https://github.com/Azure/login#readme for more information.

@ThomasRaoux
Copy link
Collaborator

We updated gcc but I think the next issue has to be fixed manually by openai, seems to be an issue with the azure login, I've gotten it 3x now:

Run azure/login@v2
Running Azure CLI Login.
/usr/bin/az cloud set -n azurecloud
Done setting cloud: "azurecloud"
Federated token details:
 issuer - https://token.actions.githubusercontent.com
 subject claim - repo:triton-lang/triton:ref:refs/heads/llvm-head
Attempting Azure CLI login by using OIDC...
Error: AADSTS700213: No matching federated identity record found for presented assertion subject 'repo:triton-lang/triton:ref:refs/heads/llvm-head'. Please note that the matching is done using a case-sensitive comparison. Check your federated identity credential Subject, Audience and Issuer against the presented assertion. https://learn.microsoft.com/entra/workload-id/workload-identity-federation Trace ID: 8c0fdcd8-f884-4e74-b06c-5f55cd206b00 Correlation ID: 1c0c3c7f-cb5c-4753-affc-10e529f19db9 Timestamp: 2024-08-22 09:28:07Z
Interactive authentication is needed. Please run:
az login

Error: Login failed with Error: The process '/usr/bin/az' failed with exit code 1. Double check if the 'auth-type' is correct. Refer to https://github.com/Azure/login#readme for more information.

in which PR do you see this error? Here I only see the previous error

@vwbaker
Copy link
Collaborator

vwbaker commented Aug 22, 2024

in which PR do you see this error? Here I only see the previous error

Triggering the LLVM Build on llvm-build branch: https://github.com/triton-lang/triton/actions/runs/10503808847

@ThomasRaoux
Copy link
Collaborator

in which PR do you see this error? Here I only see the previous error

Triggering the LLVM Build on llvm-build branch: https://github.com/triton-lang/triton/actions/runs/10503808847

it's fixed!

@vwbaker vwbaker force-pushed the llvm-1115dee248e68a155001ac3712a189299d104863 branch from 028550f to 15527a8 Compare August 28, 2024 08:32
@vwbaker
Copy link
Collaborator

vwbaker commented Aug 29, 2024

This should be ready now, sorry for all the changes :)

@ThomasRaoux
Copy link
Collaborator

Awesome, thanks @vwbaker!! If you don't mind I'll merge it tomorrow as I am working on stabilizing some infra on my side today.

@ThomasRaoux ThomasRaoux merged commit 46550ab into triton-lang:main Aug 30, 2024
7 checks passed
@vwbaker vwbaker deleted the llvm-1115dee248e68a155001ac3712a189299d104863 branch August 30, 2024 05:17
@jlebar jlebar mentioned this pull request Sep 3, 2024
Merged
@antiagainst antiagainst mentioned this pull request Sep 4, 2024
Merged
bertmaher pushed a commit to bertmaher/triton that referenced this pull request Dec 10, 2024
@khasanovaa @vwbaker
@gflegar @reichlfl @karupayun @chsigg @bertmaher
[BACKEND] Update LLVM version to llvm/llvm-project@1115dee (triton-la…
3efb390 
…ng#4537)

1. Updated llvm version up to 1115dee248e68a155001ac3712a189299d104863
2. Included fixes that are required to the codebase to correspond the
new version
3. Fixed naming and version of gcc package

---------

Co-authored-by: Tori Baker <vwbaker@google.com>
Co-authored-by: Goran Flegar <gflegar@google.com>
Co-authored-by: Florian Reichl <63750742+reichlfl@users.noreply.github.com>
Co-authored-by: Pablo Zimmermann <karupayun@google.com>
Co-authored-by: Christian Sigg <chsigg@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ThomasRaoux ThomasRaoux ThomasRaoux approved these changes

@antiagainst antiagainst Awaiting requested review from antiagainst antiagainst is a code owner

@zhanglx13 zhanglx13 Awaiting requested review from zhanglx13 zhanglx13 is a code owner

@ptillet ptillet Awaiting requested review from ptillet ptillet is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@khasanovaa @vwbaker @ThomasRaoux @gflegar @reichlfl @karupayun @chsigg