Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "[BACKEND] Update llvm to llvm/llvm-project@f142f8afe2 (#4619)" #4624

Merged
merged 1 commit into from
Aug 31, 2024

Conversation

antiagainst
Copy link
Collaborator

This reverts commit 884c0ad because it triggers the following failure in certain kernels:

llvm/lib/CodeGen/LiveVariables.cpp:159: void llvm::LiveVariables::HandleVirtRegUse (llvm::Register, llvm::MachineBasicBlock *, llvm::MachineInstr &): Assertion `MRI->getVRegDef(Reg) && "Register use before def!"' failed.

…-lang#4619)"

This reverts commit 884c0ad because
it triggers the following failure in certain kernels:

llvm/lib/CodeGen/LiveVariables.cpp:159: void llvm::LiveVariables::HandleVirtRegUse
(llvm::Register, llvm::MachineBasicBlock *, llvm::MachineInstr &):
Assertion `MRI->getVRegDef(Reg) && "Register use before def!"' failed.
@ThomasRaoux
Copy link
Collaborator

For reference the crash was due to llvm/llvm-project#105730, there is a fix later in LLVM that will be picked up by the next integrate

Copy link
Collaborator

@ThomasRaoux ThomasRaoux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@ThomasRaoux ThomasRaoux enabled auto-merge (squash) August 31, 2024 15:10
@ThomasRaoux ThomasRaoux merged commit 3d9c618 into triton-lang:main Aug 31, 2024
7 checks passed
@antiagainst antiagainst deleted the revert-llvm-commit branch August 31, 2024 15:13
ThomasRaoux pushed a commit that referenced this pull request Sep 1, 2024
This bumps to llvm/llvm-project@56152fa377 to further
include the following fix
* llvm/llvm-project#105871

Which was fixing issues in a previous LLVM bump
* #4624
bertmaher pushed a commit to bertmaher/triton that referenced this pull request Dec 10, 2024
…-lang#4619)" (triton-lang#4624)

This reverts commit 884c0ad because it
triggers the following failure in certain kernels:

llvm/lib/CodeGen/LiveVariables.cpp:159: void
llvm::LiveVariables::HandleVirtRegUse (llvm::Register,
llvm::MachineBasicBlock *, llvm::MachineInstr &): Assertion
`MRI->getVRegDef(Reg) && "Register use before def!"' failed.
bertmaher pushed a commit to bertmaher/triton that referenced this pull request Dec 10, 2024
This bumps to llvm/llvm-project@56152fa377 to further
include the following fix
* llvm/llvm-project#105871

Which was fixing issues in a previous LLVM bump
* triton-lang#4624
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants