Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cannot enable TEXT_DISPLAY entity on config #381

Closed
diogotcorreia opened this issue Jan 24, 2024 · 0 comments · Fixed by #384
Closed

Cannot enable TEXT_DISPLAY entity on config #381

diogotcorreia opened this issue Jan 24, 2024 · 0 comments · Fixed by #384
Assignees
@diogotcorreia
Labels
module:api Related to the API module:core Related to the core module module:spigot Related to Spigot/PaperMC type:bug Something isn't working as expected
Milestone
3.9.5

Comments

@diogotcorreia
Copy link
Member

EntityType enum is outdated and doesn't contain this entity.
The proper fix would be to ditch this custom enum 😅
@diogotcorreia diogotcorreia added module:api Related to the API module:core Related to the core module module:spigot Related to Spigot/PaperMC labels Jan 24, 2024
@diogotcorreia diogotcorreia added this to the 4.0.0 milestone Jan 24, 2024
@diogotcorreia diogotcorreia self-assigned this Jan 24, 2024
@diogotcorreia diogotcorreia moved this to Todo in Triton Jan 24, 2024
@diogotcorreia diogotcorreia modified the milestones: 4.0.0, 3.9.5 Jan 24, 2024
@diogotcorreia diogotcorreia added the type:bug Something isn't working as expected label Feb 1, 2024
diogotcorreia added a commit that referenced this issue Feb 1, 2024
@diogotcorreia
fix(api): update entitytype enum with new entities
e6d4480 
Fixes #381
@diogotcorreia diogotcorreia mentioned this issue Feb 1, 2024
Merged
diogotcorreia added a commit that referenced this issue Feb 1, 2024
@diogotcorreia
fix(api): update entitytype enum with new entities (#384)
2007557 
Fixes #381
@github-project-automation github-project-automation bot moved this from Todo to Done in Triton Feb 1, 2024
diogotcorreia added a commit that referenced this issue Aug 30, 2024
@diogotcorreia
fix(api): update entitytype enum with new entities (#384)
d9a6b71 
Fixes #381

Backport of 2007557 to v4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@diogotcorreia diogotcorreia

Labels
module:api Related to the API module:core Related to the core module module:spigot Related to Spigot/PaperMC type:bug Something isn't working as expected
Projects
Triton
Status: Done
Milestone
3.9.5
Development

Successfully merging a pull request may close this issue.

fix(api): update entitytype enum with new entities tritonmc/Triton
1 participant
@diogotcorreia