Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make OAuthAccessTokenParser objc compatible #100

Merged
merged 1 commit into from
Oct 19, 2016

Conversation

bckr
Copy link
Contributor

@bckr bckr commented Oct 5, 2016

Description:

With merging #79 we accidentally broke objc compatibility because of the newly introduced OAuthAccessTokenParser that exposes the Result type in our initializer.

Proposed solution:

I've changed the signature of OAuthAccessTokenParser to throw instead of returning Result

@objc public protocol OAuthAccessTokenParser {
    func parse(data: NSData) throws -> OAuthAccessToken
}

fyi: @poislagarde

@Stengo
Copy link
Contributor

Stengo commented Oct 10, 2016

Looks good to me. I think this is the nicest solution to restore objc compatibility 👍

@SusannProszak
Copy link
Contributor

👍 looks good

@bckr bckr merged commit ff6a82b into master Oct 19, 2016
@bckr bckr deleted the feature/fix-obcj-compatibility branch October 19, 2016 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants