This repository has been archived by the owner on Feb 7, 2022. It is now read-only.
injected Stats.presetToOptions to parse { stats: String } into Object #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pago
approved these changes
Jan 17, 2018
|
Thanks for the PR's looks good except there is a failing test. can you check it please. |
|
@efegurkan the weird thing is that when I run only
The only reason for this could be that different instances of class/module are compared. |
1 similar comment
efegurkan
approved these changes
Jan 19, 2018
| webpackWorker = require('../webpackWorker.js'); | ||
| notifyIPCWatchCompileDone = require('../watchModeIPC').notifyIPCWatchCompileDone; | ||
| jest.doMock('testConfig', () => ({ webpack: 'config' }), { virtual: true }); | ||
| jest.resetModules(); | ||
| jest.clearAllMocks(); | ||
| process.removeAllListeners(); |
There was a problem hiding this comment.
That explains why it was failing on test suit only. Nice catch! 😃
|
Looks good to me 👍 Thanks for the PR |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref.: https://webpack.js.org/configuration/stats/
statscould be a StringHow it's converted into object https://github.com/webpack/webpack/blob/master/lib/Stats.js#L906