Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Windows CI #58

Merged
merged 6 commits into from
Jun 25, 2024
Merged

Fix Windows CI #58

merged 6 commits into from
Jun 25, 2024

Conversation

andrewwinters5000
Copy link
Member

@andrewwinters5000 andrewwinters5000 commented Jun 25, 2024

Windows seems to take sometime to close an IOStream and a file. This bumps up the amount of idle time to avoid erroneous errors that occur with back-to-back generate_mesh and remove_mesh! calls on Windows systems.

Windows sometimes does not close the IOStream and release a file. With the advice from here adding an explicit call to the garbage collector GC.gc() before one attempts to delete the file fixes the CI issue.

Copy link

codecov bot commented Jun 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.81%. Comparing base (ee72a13) to head (621228c).

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #58   +/-   ##
=======================================
  Coverage   98.81%   98.81%           
=======================================
  Files          21       21           
  Lines        1863     1863           
=======================================
  Hits         1841     1841           
  Misses         22       22           
Flag Coverage Δ
unittests 98.81% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@coveralls
Copy link

Coverage Status

coverage: 98.819%. first build
when pulling 8469747 on fix-windows-ci
into ee72a13 on main.

@andrewwinters5000 andrewwinters5000 changed the title Bump up sleep time in testing Fix Windows CI Jun 25, 2024
@coveralls
Copy link

Coverage Status

coverage: 98.819%. first build
when pulling 621228c on fix-windows-ci
into ee72a13 on main.

@sloede sloede merged commit 6c4cf0c into main Jun 25, 2024
10 checks passed
@sloede sloede deleted the fix-windows-ci branch June 25, 2024 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants