move GeometryBasics to Makie requires block #1322
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I looked at the load times and latency issues with Julia v1.9 beta. Using the branch JuliaLang/julia#48075, this reduces the time of
using Trixi
for me fromon
main
toon this branch.
As far as I can tell, the functions I moved are not called outside of the Makie recipes stuff. We lose the ability to use specify compat bounds on GeometryBasics.jl in this way, but I hope this is no problem. This could be solved/improved in the future with conditional dependencies introduced in Julia v1.9, see https://pkgdocs.julialang.org/dev/creating-packages/#Conditional-loading-of-code-in-packages-(Extensions)
What's your take on this, @jlchan ?