Feature: Simple clamp AMR indicator.

[jmark]

Refines an element when the element average of variable lies within a given interval [a,b].
Simple, stupid, nothing fancy.

[ranocha]

Thanks! Please add tests using the new functionality.

[codecov]

Codecov Report

Attention: Patch coverage is 6.49351% with 72 lines in your changes missing coverage. Please review.

Project coverage is 96.16%. Comparing base (0c2c367) to head (5f58a09).

Files with missing lines	Patch %	Lines
src/solvers/dgsem_tree/indicators_1d.jl	0.00%	20 Missing ⚠️
src/solvers/dgsem_tree/indicators_2d.jl	0.00%	20 Missing ⚠️
src/solvers/dgsem_tree/indicators_3d.jl	0.00%	20 Missing ⚠️
src/solvers/dgsem_tree/indicators.jl	29.41%	12 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1354      +/-   ##
==========================================
- Coverage   96.34%   96.16%   -0.18%     
==========================================
  Files         470      470              
  Lines       37512    37589      +77     
==========================================
+ Hits        36140    36145       +5     
- Misses       1372     1444      +72     

Flag	Coverage Δ
unittests	96.16% <6.49%> (-0.18%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[DanielDoehring]

Maybe consider adding small explanatory comments?

[DanielDoehring]

Following Hendrik, I think this is ready to be merged once coveralls passes, i.e., once every dimensional case has been tested.

[jmark]

Following Hendrik, I think this is ready to be merged once coveralls passes, i.e., once every dimensional case has been tested.

This has to wait till #2055 is merged since with this equations I use this AMR indicator.

[DanielDoehring]

This has to wait till #2055 is merged since with this equations I use this AMR indicator.

Is not the opposite the case - you need this for #2055 ? 🤔

[DanielDoehring]

We should stick to english - or replace type with something like indicator_clamp (I think this convention is used at different places)