Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature t8code: Extending to 3D #1535

Merged
merged 169 commits into from
Jan 19, 2024
Merged

Feature t8code: Extending to 3D #1535

merged 169 commits into from
Jan 19, 2024

Conversation

jmark
Copy link
Contributor

@jmark jmark commented Jun 19, 2023

This PR extends #1426 to 3D. Still in draft. Gonna need more testing, polishing and more tests should be written.

Johannes Markert and others added 30 commits May 5, 2023 16:29
Initial commit for the new feature using t8code as meshing backend.
db1ea6b
@jmark
Delete t8code_2d_dgsem
2cac6c9
Added new examples and tests. Testing updates for T8code.jl.
1bb2061
Merge branch 'feature-t8code' of github.com:trixi-framework/Trixi.jl …
ba920cd 
…into feature-t8code
Worked in the comments.
1cab250
@jmark
Merge branch 'main' into feature-t8code
edf6a91
Fixed spelling.
cdced17
@jmark @ranocha
Update src/auxiliary/auxiliary.jl
d02d32e 
Co-authored-by: Hendrik Ranocha <ranocha@users.noreply.github.com>
Added whitespace in Unions.
7c01df0
Adapted commented out code block reporting the no. of elements per le…
e6cd1ab 
…vel.
Added dummy save mesh support for .
0abdcd9
Added test .
10ac87d
Added to method signature.
349136a
Deleted unnecessary comments.
3e47616
Removed commented out tests.
fe6d874
Fixed Morton ordering bug in 2D at mortar interfaces.
d5d6298
Disabled save_solution callbacks and added more tests.
9c0db6f
Added more tests.
1440f90
@jmark
Merge branch 'main' into feature-t8code
85a34df
Updated code according to the review.
068558f
@jmark
Merge branch 'main' into feature-t8code
1fab9b9
@jmark
Merge branch 'main' into feature-t8code
6dcca7b
@jmark @ranocha
Update src/auxiliary/t8code.jl
497f957 
Co-authored-by: Hendrik Ranocha <ranocha@users.noreply.github.com>
@jmark @ranocha
Update src/auxiliary/t8code.jl
4a958c4 
Co-authored-by: Hendrik Ranocha <ranocha@users.noreply.github.com>
@jmark @ranocha
Update src/auxiliary/t8code.jl
3d869b0 
Co-authored-by: Hendrik Ranocha <ranocha@users.noreply.github.com>
@jmark @ranocha
Update src/auxiliary/t8code.jl
c04b0f0 
Co-authored-by: Hendrik Ranocha <ranocha@users.noreply.github.com>
@jmark @ranocha
Update src/meshes/t8code_mesh.jl
5396b87 
Co-authored-by: Hendrik Ranocha <ranocha@users.noreply.github.com>
@jmark @ranocha
Update src/meshes/t8code_mesh.jl
095fdbc 
Co-authored-by: Hendrik Ranocha <ranocha@users.noreply.github.com>
@jmark @ranocha
Update src/meshes/t8code_mesh.jl
3222693 
Co-authored-by: Hendrik Ranocha <ranocha@users.noreply.github.com>
@jmark @ranocha
Update src/meshes/t8code_mesh.jl
db52949 
Co-authored-by: Hendrik Ranocha <ranocha@users.noreply.github.com>
ranocha
ranocha requested changes Jan 17, 2024
View reviewed changes
Copy link
Member

@ranocha ranocha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot! Please find some comments below.

examples/t8code_3d_dgsem/elixir_advection_nonconforming.jl Outdated Show resolved Hide resolved
examples/t8code_3d_dgsem/elixir_advection_nonconforming.jl Outdated Show resolved Hide resolved
examples/t8code_3d_dgsem/elixir_euler_free_stream.jl Outdated Show resolved Hide resolved
src/meshes/t8code_mesh.jl Show resolved Hide resolved
test/test_t8code_3d.jl Outdated Show resolved Hide resolved
test/test_t8code_3d.jl Show resolved Hide resolved
benegee and others added 2 commits January 17, 2024 12:38
@benegee @ranocha
Apply suggestions from code review
40624af 
Co-authored-by: Hendrik Ranocha <ranocha@users.noreply.github.com>
@benegee
add missing allocation checks
5c7cfbc
andrewwinters5000
andrewwinters5000 reviewed Jan 17, 2024
View reviewed changes
Copy link
Member

@andrewwinters5000 andrewwinters5000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good from my end of things. Once the comments from the others are resolved I think it is good to go.

@benegee benegee requested a review from ranocha January 18, 2024 15:59
ranocha
ranocha reviewed Jan 19, 2024
View reviewed changes
src/Trixi.jl Outdated Show resolved Hide resolved
src/meshes/t8code_mesh.jl Show resolved Hide resolved
test/test_t8code_2d.jl Outdated Show resolved Hide resolved
test/test_t8code_2d.jl Outdated Show resolved Hide resolved
ranocha
ranocha reviewed Jan 19, 2024
View reviewed changes
src/meshes/t8code_mesh.jl Outdated Show resolved Hide resolved
benegee and others added 6 commits January 19, 2024 14:06
@benegee @ranocha @JoshuaLampert
Apply suggestions from code review
28b1244 
Co-authored-by: Hendrik Ranocha <ranocha@users.noreply.github.com>
Co-authored-by: Joshua Lampert <51029046+JoshuaLampert@users.noreply.github.com>
Turned @warn to @info.
cae1cbb
Code cleanup and added @deprecated routines in order to avoid breakin…
e055f5a 
…g release.
Merge branch 'feature-t8code-3d' of github.com:trixi-framework/Trixi.…
38aa10b 
…jl into feature-t8code-3d
Applied formatter.
4a1b775
Added formatter pragmas to avoid ugly formatting.
6e79e6a
ranocha
ranocha approved these changes Jan 19, 2024
View reviewed changes
Copy link
Member

@ranocha ranocha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot! Great work 👍

@ranocha ranocha enabled auto-merge (squash) January 19, 2024 14:07
@ranocha ranocha merged commit 1946f9d into main Jan 19, 2024
36 checks passed
@ranocha ranocha deleted the feature-t8code-3d branch January 19, 2024 14:45
@patrickersing patrickersing mentioned this pull request Feb 13, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sloede sloede sloede left review comments

@andrewwinters5000 andrewwinters5000 andrewwinters5000 left review comments

@JoshuaLampert JoshuaLampert JoshuaLampert left review comments

@DanielDoehring DanielDoehring DanielDoehring left review comments

@benegee benegee benegee left review comments

@ranocha ranocha ranocha approved these changes

Assignees

@ranocha ranocha

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@jmark @sloede @DanielDoehring @ranocha @andrewwinters5000 @JoshuaLampert @benegee