Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Paired Explicit Runge-Kutta Integrator: Third Order #2008

Open
wants to merge 137 commits into
base: main
Choose a base branch
from

Conversation

warisa-r
Copy link
Contributor

@warisa-r warisa-r commented Jul 9, 2024

This PR introduces a new single-step paired explicit Runge-Kutta integrator of the third order. Along with this implementation, NLsolve has been added as a weak dependency.

Tests have been added for the example elixir_burgers_perk3.jl both with and without the fixed time step. Additionally, methods_PERK2.jl is also modified so that some functions can also be called by the third-order integrator.

Please feel free to let me know if there is anything that is missing or needs improvement!

warisa-r and others added 30 commits May 25, 2024 17:52
Co-authored-by: Daniel Doehring <doehringd2@gmail.com>
Co-authored-by: Daniel Doehring <doehringd2@gmail.com>
Co-authored-by: Daniel Doehring <doehringd2@gmail.com>
Co-authored-by: Daniel Doehring <doehringd2@gmail.com>
Co-authored-by: Daniel Doehring <doehringd2@gmail.com>
Co-authored-by: Daniel Doehring <doehringd2@gmail.com>
Co-authored-by: Daniel Doehring <doehringd2@gmail.com>
Co-authored-by: Daniel Doehring <doehringd2@gmail.com>
Co-authored-by: Daniel Doehring <doehringd2@gmail.com>
warisa-r and others added 4 commits July 27, 2024 11:16
Co-authored-by: Joshua Lampert <51029046+JoshuaLampert@users.noreply.github.com>
Co-authored-by: Joshua Lampert <51029046+JoshuaLampert@users.noreply.github.com>
ext/TrixiNLsolveExt.jl Outdated Show resolved Hide resolved
ext/TrixiNLsolveExt.jl Outdated Show resolved Hide resolved
ext/TrixiNLsolveExt.jl Outdated Show resolved Hide resolved
ext/TrixiNLsolveExt.jl Outdated Show resolved Hide resolved
ext/TrixiNLsolveExt.jl Show resolved Hide resolved
warisa-r and others added 7 commits July 27, 2024 21:44
Co-authored-by: Joshua Lampert <51029046+JoshuaLampert@users.noreply.github.com>
Co-authored-by: Joshua Lampert <51029046+JoshuaLampert@users.noreply.github.com>
Co-authored-by: Joshua Lampert <51029046+JoshuaLampert@users.noreply.github.com>
DanielDoehring
DanielDoehring previously approved these changes Aug 13, 2024
Copy link
Contributor

@DanielDoehring DanielDoehring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks @warisa-r !

Copy link
Member

@ranocha ranocha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@warisa-r
Copy link
Contributor Author

warisa-r commented Oct 10, 2024

As #2083 has been merged, per @DanielDoehring instructions, I have added the attribute dt_opt to PairedExplicitRK3 so that calculate_cfl can also be used with this time integrator. Along with this change, an example of how calculate_cfl works with PairedExplicitRK3, elixir_burgers_perk3_optimal_cfl.jl and its test are created.

Please let me know if there is any feedback!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants