-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Paired Explicit Runge-Kutta Integrator: Third Order #2008
base: main
Are you sure you want to change the base?
Conversation
…i.jl into PERK_p3_single_ext
Co-authored-by: Daniel Doehring <doehringd2@gmail.com>
Co-authored-by: Daniel Doehring <doehringd2@gmail.com>
Co-authored-by: Daniel Doehring <doehringd2@gmail.com>
Co-authored-by: Daniel Doehring <doehringd2@gmail.com>
Co-authored-by: Daniel Doehring <doehringd2@gmail.com>
Co-authored-by: Daniel Doehring <doehringd2@gmail.com>
Co-authored-by: Daniel Doehring <doehringd2@gmail.com>
Co-authored-by: Daniel Doehring <doehringd2@gmail.com>
Co-authored-by: Daniel Doehring <doehringd2@gmail.com>
Co-authored-by: Joshua Lampert <51029046+JoshuaLampert@users.noreply.github.com>
Co-authored-by: Joshua Lampert <51029046+JoshuaLampert@users.noreply.github.com>
Co-authored-by: Joshua Lampert <51029046+JoshuaLampert@users.noreply.github.com>
Co-authored-by: Joshua Lampert <51029046+JoshuaLampert@users.noreply.github.com>
Co-authored-by: Joshua Lampert <51029046+JoshuaLampert@users.noreply.github.com>
… directly" since it is breaking
…coeffs_unknown! function
src/time_integration/paired_explicit_runge_kutta/methods_PERK3.jl
Outdated
Show resolved
Hide resolved
src/time_integration/paired_explicit_runge_kutta/methods_PERK3.jl
Outdated
Show resolved
Hide resolved
src/time_integration/paired_explicit_runge_kutta/methods_PERK3.jl
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, thanks @warisa-r !
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The CI failure is caused by this PR:
As #2083 has been merged, per @DanielDoehring instructions, I have added the attribute Please let me know if there is any feedback! |
This PR introduces a new single-step paired explicit Runge-Kutta integrator of the third order. Along with this implementation, NLsolve has been added as a weak dependency.
Tests have been added for the example elixir_burgers_perk3.jl both with and without the fixed time step. Additionally,
methods_PERK2.jl
is also modified so that some functions can also be called by the third-order integrator.Please feel free to let me know if there is anything that is missing or needs improvement!