Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Taal: add trixi_include and move definitions of abstract types for dispatch #202

Merged
merged 4 commits into from
Oct 6, 2020

Conversation

ranocha
Copy link
Member

@ranocha ranocha commented Oct 6, 2020

This resolves some comments left in #187.

@ranocha ranocha requested a review from sloede October 6, 2020 10:40
@codecov
Copy link

codecov bot commented Oct 6, 2020

Codecov Report

Merging #202 into dev will decrease coverage by 0.01%.
The diff coverage is 47.61%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #202      +/-   ##
==========================================
- Coverage   89.24%   89.22%   -0.02%     
==========================================
  Files          52       52              
  Lines        9923     9935      +12     
==========================================
+ Hits         8856     8865       +9     
- Misses       1067     1070       +3     
Impacted Files Coverage Δ
src/Trixi.jl 100.00% <ø> (ø)
src/callbacks/alive.jl 82.60% <ø> (ø)
src/equations/equations.jl 81.63% <ø> (ø)
src/semidiscretization.jl 60.00% <ø> (ø)
src/solvers/dg/dg.jl 68.79% <0.00%> (ø)
src/solvers/dg/dg_2d.jl 85.03% <0.00%> (ø)
src/run.jl 93.63% <75.00%> (-0.88%) ⬇️
src/auxiliary/auxiliary.jl 86.84% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update abd7087...4559998. Read the comment docs.

src/run.jl Show resolved Hide resolved
src/solvers/dg/dg_2d.jl Show resolved Hide resolved
@ranocha
Copy link
Member Author

ranocha commented Oct 6, 2020

If this looks good for you, could you please approve it explicitly (using GitHub's review tools)? I think it would be nice if we got used to approving PRs explicitly like that.

@sloede
Copy link
Member

sloede commented Oct 6, 2020

If this looks good for you, could you please approve it explicitly (using GitHub's review tools)? I think it would be nice if we got used to approving PRs explicitly like that.

I strongly concur!

@ranocha
Copy link
Member Author

ranocha commented Oct 6, 2020

Thanks!

@ranocha ranocha merged commit b37c070 into trixi-framework:dev Oct 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants