-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Further updates to Taal #212
Conversation
…SemidiscretizationEulerGravity
Codecov Report
@@ Coverage Diff @@
## dev #212 +/- ##
===========================================
+ Coverage 70.46% 89.12% +18.65%
===========================================
Files 57 58 +1
Lines 10440 10427 -13
===========================================
+ Hits 7357 9293 +1936
+ Misses 3083 1134 -1949
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Additional general remarks:
- Shouldn't
elixir_jeans_instability.jl
be namedelixir_euler_gravity_jeans_instability.jl
(for consistency)?
Yeah, thanks for catching that! |
Based on comments of @sloede in #200. Feel free to merge when everything looks okay to you. Otherwise, we can continue our discussion here.