Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Further updates to Taal #212

Merged
merged 14 commits into from
Oct 11, 2020
Merged

Further updates to Taal #212

merged 14 commits into from
Oct 11, 2020

Conversation

ranocha
Copy link
Member

@ranocha ranocha commented Oct 9, 2020

Based on comments of @sloede in #200. Feel free to merge when everything looks okay to you. Otherwise, we can continue our discussion here.

@ranocha ranocha requested a review from sloede October 9, 2020 09:28
@codecov
Copy link

codecov bot commented Oct 9, 2020

Codecov Report

Merging #212 into dev will increase coverage by 18.65%.
The diff coverage is 46.03%.

Impacted file tree graph

@@             Coverage Diff             @@
##              dev     #212       +/-   ##
===========================================
+ Coverage   70.46%   89.12%   +18.65%     
===========================================
  Files          57       58        +1     
  Lines       10440    10427       -13     
===========================================
+ Hits         7357     9293     +1936     
+ Misses       3083     1134     -1949     
Impacted Files Coverage Δ
src/callbacks/analysis_dg2d.jl 90.00% <ø> (ø)
src/run.jl 93.63% <ø> (ø)
src/semidiscretization.jl 73.56% <ø> (+13.56%) ⬆️
src/solvers/dg/dg.jl 84.78% <ø> (+17.88%) ⬆️
src/solvers/dg/indicators_1d.jl 65.16% <ø> (ø)
src/solvers/dg/indicators_2d.jl 66.34% <ø> (ø)
src/solvers/dg/interpolation.jl 79.54% <ø> (+15.17%) ⬆️
src/solvers/dg/indicators.jl 35.84% <35.84%> (ø)
src/auxiliary/auxiliary.jl 86.84% <100.00%> (ø)
src/callbacks/amr_dg1d.jl 94.01% <100.00%> (+0.10%) ⬆️
... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0cde779...9d136d8. Read the comment docs.

Copy link
Member

@sloede sloede left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Additional general remarks:

  • Shouldn't elixir_jeans_instability.jl be named elixir_euler_gravity_jeans_instability.jl (for consistency)?

docs/src/development.md Show resolved Hide resolved
test/test_elixirs.jl Show resolved Hide resolved
src/callbacks/amr_dg1d.jl Show resolved Hide resolved
@ranocha
Copy link
Member Author

ranocha commented Oct 11, 2020

Shouldn't elixir_jeans_instability.jl be named elixir_euler_gravity_jeans_instability.jl (for consistency)?

Yeah, thanks for catching that!

@ranocha ranocha requested a review from sloede October 11, 2020 07:03
@sloede sloede merged commit 1bfa48e into trixi-framework:dev Oct 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants