Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More updates to Taal #218

Merged
merged 19 commits into from
Oct 12, 2020
Merged

More updates to Taal #218

merged 19 commits into from
Oct 12, 2020

Conversation

ranocha
Copy link
Member

@ranocha ranocha commented Oct 12, 2020

Based on comments of @sloede in #200. Let's iterate another round.

@ranocha ranocha requested a review from sloede October 12, 2020 04:53
src/mesh/mesh.jl Outdated Show resolved Hide resolved
src/semidiscretization.jl Show resolved Hide resolved
src/solvers/dg/dg_1d.jl Outdated Show resolved Hide resolved
src/solvers/dg/dg_1d.jl Outdated Show resolved Hide resolved
src/solvers/dg/dg_2d.jl Outdated Show resolved Hide resolved
src/solvers/dg/dg_2d.jl Outdated Show resolved Hide resolved
src/solvers/dg/indicators.jl Outdated Show resolved Hide resolved
src/solvers/dg/indicators.jl Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Oct 12, 2020

Codecov Report

Merging #218 into dev will decrease coverage by 2.44%.
The diff coverage is 81.96%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #218      +/-   ##
==========================================
- Coverage   91.53%   89.09%   -2.45%     
==========================================
  Files          36       58      +22     
  Lines        8037    10434    +2397     
==========================================
+ Hits         7357     9296    +1939     
- Misses        680     1138     +458     
Impacted Files Coverage Δ
src/Trixi.jl 100.00% <ø> (ø)
src/equations/3d/hyperbolic_diffusion.jl 78.98% <0.00%> (-0.51%) ⬇️
src/solvers/dg/3d/dg.jl 92.10% <0.00%> (ø)
src/solvers/solvers.jl 90.90% <ø> (ø)
src/solvers/dg/indicators.jl 35.84% <35.84%> (ø)
src/auxiliary/containers.jl 90.75% <42.85%> (ø)
src/equations/3d/ideal_glm_mhd.jl 92.49% <50.00%> (-0.21%) ⬇️
src/mesh/tree.jl 94.63% <50.00%> (ø)
src/solvers/dg/3d/containers.jl 91.80% <50.00%> (-0.14%) ⬇️
src/equations/2d/linear_scalar_advection.jl 77.50% <55.55%> (-3.59%) ⬇️
... and 63 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2c670e2...db82604. Read the comment docs.

@ranocha ranocha requested a review from sloede October 12, 2020 05:27
@ranocha ranocha merged commit f400d53 into trixi-framework:dev Oct 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants