Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Taal 3D #255

Merged
merged 7 commits into from
Oct 28, 2020
Merged

Taal 3D #255

merged 7 commits into from
Oct 28, 2020

Conversation

ranocha
Copy link
Member

@ranocha ranocha commented Oct 27, 2020

I've ported most 3D functionality to Taal and set up some first tests. I suggest to merge this PR first and port the remaining examples later - which could also be done by other @trixi-framework/developers.

@ranocha ranocha marked this pull request as draft October 27, 2020 17:43
@ranocha ranocha added the taal label Oct 27, 2020
@ranocha ranocha mentioned this pull request Oct 27, 2020
45 tasks
@ranocha ranocha closed this Oct 27, 2020
@ranocha ranocha reopened this Oct 27, 2020
@codecov
Copy link

codecov bot commented Oct 27, 2020

Codecov Report

Merging #255 into dev will decrease coverage by 1.27%.
The diff coverage is 67.09%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #255      +/-   ##
==========================================
- Coverage   89.41%   88.14%   -1.28%     
==========================================
  Files          60       66       +6     
  Lines       10585    12601    +2016     
==========================================
+ Hits         9465    11107    +1642     
- Misses       1120     1494     +374     
Impacted Files Coverage Δ
src/callbacks/amr.jl 87.50% <ø> (ø)
src/callbacks/amr_dg1d.jl 95.04% <ø> (ø)
src/callbacks/analysis.jl 83.41% <ø> (ø)
src/callbacks/steady_state.jl 68.42% <ø> (ø)
src/callbacks/stepsize.jl 85.29% <ø> (ø)
src/equations/2d/compressible_euler.jl 91.80% <ø> (ø)
src/solvers/dg/dg.jl 81.91% <ø> (ø)
src/solvers/dg/indicators_1d.jl 65.16% <0.00%> (ø)
src/solvers/dg/indicators_2d.jl 66.34% <0.00%> (ø)
src/solvers/dg/interpolation.jl 75.26% <0.00%> (-4.28%) ⬇️
... and 32 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 222241f...8ad4a6f. Read the comment docs.

@ranocha ranocha changed the title WIP: Taal 3d Taal 3D Oct 28, 2020
@ranocha ranocha requested a review from sloede October 28, 2020 09:15
@ranocha ranocha marked this pull request as ready for review October 28, 2020 09:15
Copy link
Member

@sloede sloede left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I have to be honest - I only really looked at the files with changes, but did not check in detail the contents of the new files, e.g., indicators_3d, dg_3d etc. Just reading through thousands of lines is probably not gonna catch the errors, so I think I'd better use the time to make sure that in the end the test results match between Taal and Taam.

If you disagree, then I'll have to do a more thorough review later on, but it is going to take me a while...

@ranocha
Copy link
Member Author

ranocha commented Oct 28, 2020

Just reading through thousands of lines is probably not gonna catch the errors, so I think I'd better use the time to make sure that in the end the test results match between Taal and Taam.

That's perfectly fine and also what I had in mind when creating this PR - create a basis for discussing Taal further and build everything on top of your nice work comparing Taal and Taam 👍

@ranocha ranocha merged commit d00de5f into trixi-framework:dev Oct 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants