-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Taal 3D #255
Taal 3D #255
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #255 +/- ##
==========================================
- Coverage 89.41% 88.14% -1.28%
==========================================
Files 60 66 +6
Lines 10585 12601 +2016
==========================================
+ Hits 9465 11107 +1642
- Misses 1120 1494 +374
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I have to be honest - I only really looked at the files with changes, but did not check in detail the contents of the new files, e.g., indicators_3d, dg_3d etc. Just reading through thousands of lines is probably not gonna catch the errors, so I think I'd better use the time to make sure that in the end the test results match between Taal and Taam.
If you disagree, then I'll have to do a more thorough review later on, but it is going to take me a while...
That's perfectly fine and also what I had in mind when creating this PR - create a basis for discussing Taal further and build everything on top of your nice work comparing Taal and Taam 👍 |
I've ported most 3D functionality to Taal and set up some first tests. I suggest to merge this PR first and port the remaining examples later - which could also be done by other @trixi-framework/developers.