Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update docs to Taal and fix typos #298

Merged
merged 2 commits into from
Nov 6, 2020
Merged

update docs to Taal and fix typos #298

merged 2 commits into from
Nov 6, 2020

Conversation

ranocha
Copy link
Member

@ranocha ranocha commented Nov 5, 2020

This updates the docs to Taal (elixirs instead of parameter files etc.). I've also left a TODO note for you, @sloede.

@ranocha ranocha requested a review from sloede November 5, 2020 14:51
@ranocha ranocha added documentation Improvements or additions to documentation taal labels Nov 5, 2020
Copy link
Member

@sloede sloede left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Also, I didn't find the todo note you left for me, so I'd go as far as to say that it looks excellent to me ;-)

README.md Show resolved Hide resolved
README.md Show resolved Hide resolved
docs/src/index.md Outdated Show resolved Hide resolved
@sloede
Copy link
Member

sloede commented Nov 5, 2020

Oops, I didn't mean to approve just yet... Please have a look at my comments first 😬

@codecov
Copy link

codecov bot commented Nov 5, 2020

Codecov Report

Merging #298 into dev will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev     #298   +/-   ##
=======================================
  Coverage   87.79%   87.79%           
=======================================
  Files          79       79           
  Lines       13141    13141           
=======================================
  Hits        11537    11537           
  Misses       1604     1604           
Flag Coverage Δ
unittests 87.79% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/Trixi.jl 100.00% <ø> (ø)
src/equations/1d/linear_scalar_advection.jl 79.10% <ø> (ø)
src/equations/2d/linear_scalar_advection.jl 76.74% <ø> (ø)
src/equations/3d/linear_scalar_advection.jl 75.43% <ø> (ø)
src/run.jl 93.64% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2fc8f92...b9d7056. Read the comment docs.

@ranocha ranocha requested a review from sloede November 5, 2020 16:01
@ranocha ranocha merged commit f41b8e6 into dev Nov 6, 2020
@ranocha ranocha deleted the taal_docs branch November 6, 2020 05:45
@ranocha ranocha mentioned this pull request Nov 9, 2020
45 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation taal
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants