Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Port & mix last 3D elixirs #311

Merged
merged 24 commits into from
Nov 10, 2020
Merged

Port & mix last 3D elixirs #311

merged 24 commits into from
Nov 10, 2020

Conversation

sloede
Copy link
Member

@sloede sloede commented Nov 9, 2020

No description provided.

@ranocha ranocha mentioned this pull request Nov 9, 2020
Closed
@ranocha
Copy link
Member

ranocha commented Nov 10, 2020

Will this close #219?

@sloede
Copy link
Member Author

sloede commented Nov 10, 2020

I think so, yes. But just to be sure, we could also close #219 on merging #267.

@sloede sloede marked this pull request as ready for review November 10, 2020 09:47
@sloede sloede requested a review from ranocha November 10, 2020 09:47
@Cczernik Cczernik self-requested a review November 10, 2020 10:18
ranocha
ranocha requested changes Nov 10, 2020
View reviewed changes
Copy link
Member

@ranocha ranocha left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM after minor revisions 👍

Note: I didn't check whether tests pass or the setups and errors of confirmed tests match etc.

examples/3d/elixir_euler_amr.jl Outdated Show resolved Hide resolved
examples/3d/elixir_euler_amr.jl Outdated Show resolved Hide resolved
examples/3d/elixir_euler_sedov_blast_wave_shockcapturing_amr.jl Outdated Show resolved Hide resolved
examples/3d/elixir_euler_sedov_blast_wave_shockcapturing_amr.jl Outdated Show resolved Hide resolved
examples/3d/elixir_euler_sedov_blast_wave_shockcapturing_amr.jl Outdated Show resolved Hide resolved
test/test_examples_3d.jl Outdated Show resolved Hide resolved
test/test_examples_3d.jl Outdated Show resolved Hide resolved
test/test_examples_3d.jl Outdated Show resolved Hide resolved
test/test_examples_3d.jl Outdated Show resolved Hide resolved
test/test_examples_3d.jl Outdated Show resolved Hide resolved
sloede and others added 3 commits November 10, 2020 11:31
@sloede sloede requested a review from ranocha November 10, 2020 13:13
@ranocha ranocha merged commit fa1fd45 into msl/sync-taal-taam Nov 10, 2020
@ranocha ranocha deleted the msl/3d-or-not-3d branch November 10, 2020 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ranocha ranocha ranocha approved these changes

@Cczernik Cczernik Cczernik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sloede @ranocha @Cczernik