Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deprecate calcflux -> flux #463

Merged
merged 3 commits into from
Mar 13, 2021
Merged

deprecate calcflux -> flux #463

merged 3 commits into from
Mar 13, 2021

Conversation

ranocha
Copy link
Member

@ranocha ranocha commented Mar 11, 2021

I requested a review of @trixi-framework/principal-developers to make them aware of this change and let them add their thoughts here.

Closes #459

Copy link
Member

@sloede sloede left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! But I'd like the other @trixi-framework/principal-developers to weigh in as well...

@codecov
Copy link

codecov bot commented Mar 11, 2021

Codecov Report

Merging #463 (c2a2d12) into main (a57a682) will increase coverage by 4.52%.
The diff coverage is 83.65%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #463      +/-   ##
==========================================
+ Coverage   90.36%   94.88%   +4.52%     
==========================================
  Files         101      101              
  Lines       11235    11353     +118     
==========================================
+ Hits        10152    10772     +620     
+ Misses       1083      581     -502     
Flag Coverage Δ
unittests 94.88% <83.65%> (+4.52%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/Trixi.jl 100.00% <ø> (ø)
src/equations/lattice_boltzmann_2d.jl 92.98% <0.00%> (+5.84%) ⬆️
src/equations/lattice_boltzmann_3d.jl 91.42% <0.00%> (+6.66%) ⬆️
src/equations/linear_scalar_advection_1d.jl 82.25% <0.00%> (+1.61%) ⬆️
src/equations/linear_scalar_advection_2d.jl 81.48% <0.00%> (+3.70%) ⬆️
src/equations/linear_scalar_advection_3d.jl 82.69% <0.00%> (+5.76%) ⬆️
src/equations/acoustic_perturbation_2d.jl 92.53% <66.66%> (+5.97%) ⬆️
.../equations/compressible_euler_multicomponent_2d.jl 97.55% <66.66%> (+1.50%) ⬆️
src/equations/equations.jl 84.37% <66.66%> (+1.04%) ⬆️
src/equations/hyperbolic_diffusion_1d.jl 86.41% <66.66%> (+3.70%) ⬆️
... and 106 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a57a682...c2a2d12. Read the comment docs.

@gregorgassner
Copy link
Contributor

I like the change from calc flux to flux!

@ranocha ranocha enabled auto-merge (squash) March 12, 2021 12:25
@ranocha ranocha merged commit 7d57c84 into trixi-framework:main Mar 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename calcflux
3 participants