Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup examples #592

Merged
merged 16 commits into from
Aug 12, 2024
Merged

Cleanup examples #592

merged 16 commits into from
Aug 12, 2024

Conversation

svchb
Copy link
Collaborator

@svchb svchb commented Aug 6, 2024

No description provided.

@svchb svchb marked this pull request as draft August 6, 2024 23:22
Copy link

codecov bot commented Aug 6, 2024

Codecov Report

Attention: Patch coverage is 33.33333% with 2 lines in your changes missing coverage. Please review.

Project coverage is 69.92%. Comparing base (f7906a5) to head (d91177c).

Files Patch % Lines
src/general/semidiscretization.jl 33.33% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #592      +/-   ##
==========================================
- Coverage   69.94%   69.92%   -0.03%     
==========================================
  Files          86       86              
  Lines        5118     5120       +2     
==========================================
  Hits         3580     3580              
- Misses       1538     1540       +2     
Flag Coverage Δ
unit 69.92% <33.33%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@svchb svchb marked this pull request as ready for review August 8, 2024 06:49
@svchb svchb requested a review from efaulhaber August 8, 2024 06:51
src/general/semidiscretization.jl Outdated Show resolved Hide resolved
src/general/semidiscretization.jl Outdated Show resolved Hide resolved
test/examples/examples.jl Outdated Show resolved Hide resolved
test/examples/examples.jl Outdated Show resolved Hide resolved
@svchb svchb requested a review from LasNikas August 8, 2024 07:20
test/examples/examples.jl Outdated Show resolved Hide resolved
@svchb svchb requested a review from LasNikas August 8, 2024 08:09
LasNikas
LasNikas previously approved these changes Aug 8, 2024
examples/fluid/accelerated_tank_2d.jl Show resolved Hide resolved
src/general/semidiscretization.jl Outdated Show resolved Hide resolved
src/general/semidiscretization.jl Outdated Show resolved Hide resolved
test/examples/examples.jl Outdated Show resolved Hide resolved
test/examples/examples.jl Outdated Show resolved Hide resolved
test/examples/examples.jl Outdated Show resolved Hide resolved
test/examples/examples.jl Outdated Show resolved Hide resolved
@svchb svchb requested a review from efaulhaber August 9, 2024 15:17
Copy link
Member

@efaulhaber efaulhaber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you checked that all these trixi_include commands give you the simulations you want? It's easy to miss something and end up with an incorrect simulation setup.

@svchb
Copy link
Collaborator Author

svchb commented Aug 12, 2024

Have you checked that all these trixi_include commands give you the simulations you want? It's easy to miss something and end up with an incorrect simulation setup.

yes I have just scrolled through again. As far as I know everything should be fine. At least all of the values that are defined are used.

@svchb svchb merged commit cca739d into trixi-framework:main Aug 12, 2024
8 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants