Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip empty systems #606

Merged
merged 2 commits into from
Sep 19, 2024
Merged

Conversation

svchb
Copy link
Collaborator

@svchb svchb commented Aug 20, 2024

With open boundaries a system can be empty. Lets skip them in the IO step.

Extracted from #604

@svchb svchb added the bug Something isn't working label Aug 20, 2024
@svchb svchb requested a review from efaulhaber August 20, 2024 15:36
Copy link

codecov bot commented Aug 20, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 69.89%. Comparing base (a27700b) to head (eaa5d96).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/visualization/write2vtk.jl 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #606      +/-   ##
==========================================
- Coverage   69.92%   69.89%   -0.03%     
==========================================
  Files          86       86              
  Lines        5120     5122       +2     
==========================================
  Hits         3580     3580              
- Misses       1540     1542       +2     
Flag Coverage Δ
unit 69.89% <0.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@efaulhaber efaulhaber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't look like a great solution to me, as VTK files are missing for some steps. But considering that VTK writing currently doesn't work for 0 particles, it's at least better than before.

@LasNikas LasNikas enabled auto-merge (squash) September 19, 2024 10:35
@LasNikas LasNikas merged commit bf951ba into trixi-framework:main Sep 19, 2024
8 of 10 checks passed
@svchb svchb mentioned this pull request Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants