- Added the Mod .sqr method.

trizen · Nov 3, 2022 · 426b3d3 · 426b3d3
1 parent 3896b9a
commit 426b3d3
Show file tree

Hide file tree

Showing 4 changed files with 45 additions and 0 deletions.
diff --git a/lib/Sidef/Types/Number/Mod.pm b/lib/Sidef/Types/Number/Mod.pm
@@ -206,6 +206,11 @@ package Sidef::Types::Number::Mod {
         __PACKAGE__->new($x->{n}->sqrtmod($x->{m}), $x->{m});
     }
 
+    sub sqr {
+        my ($x) = @_;
+        __PACKAGE__->new($x->{n}->sqr, $x->{m});
+    }
+
     sub znorder {
         my ($x) = @_;
         $x->{n}->znorder($x->{m});

diff --git a/lib/Sidef/Types/Number/Mod.pod b/lib/Sidef/Types/Number/Mod.pod
@@ -449,6 +449,14 @@ Aliases: I<real>
 
 =cut
 
+=head2 sqr
+
+    Mod.sqr()
+
+Returns the
+
+=cut
+
 =head2 sqrt
 
     Mod.sqrt()

diff --git a/lib/Sidef/Types/Number/Number.pm b/lib/Sidef/Types/Number/Number.pm
@@ -3300,6 +3300,7 @@ package Sidef::Types::Number::Number {
       Scalar__Scalar: {
             if ($x > 0 and $y >= 0) {
                 if (CORE::log($x) * $y < CORE::log(ULONG_MAX)) {
+                    $x == 1 and return 1;
                     my $r = (HAS_NEW_PRIME_UTIL ? Math::Prime::Util::powint($x, $y) : Math::Prime::Util::GMP::powint($x, $y));
                     if ($r < ULONG_MAX and $r > LONG_MIN) {
                         return $r;

diff --git a/scripts/Tests/mod_class.sf b/scripts/Tests/mod_class.sf
@@ -87,4 +87,35 @@ do {
     assert_eq(B.inv**2 -> flat.map{.mod(m)}, B.powmod(-2, m).flat)
 }
 
+do {
+    var n = 1e40.random_prime
+
+    assert_eq(Mod(2, n)**n, 2)
+    assert_eq(Mod(2, n)**(n-1), 1)
+
+    assert_eq(Gauss(Mod(2, n), 0)**(n-1), 1)
+    assert_eq(Gauss(Mod(2, n), Mod(0, n))**(n-1), 1)
+    assert_eq(Gauss(Mod(3, n), 0)**n, 3)
+
+    assert_eq(Quadratic(Mod(3, n))**n, 3)
+    assert_eq(Quadratic(Mod(3, n))**(n-1), 1)
+
+    assert_eq(Quaternion(Mod(3, n))**n, 3)
+    assert_eq(Quaternion(Mod(3, n))**(n-1), 1)
+
+    assert_eq(Mod(Fraction(2, 1), n)**n, 2)
+    assert_eq(Mod(Fraction(2, 1), n)**(n-1), 1)
+    assert_eq(Mod(Fraction(2, 1), Fraction(n, 1))**n, 2)
+    assert_eq(Mod(Fraction(2, 1), Fraction(n, 1))**(n-1), 1)
+
+    assert_eq(Fraction(Mod(2, n), Mod(1, n))**n, 2)
+    assert_eq(Fraction(Mod(2, n), Mod(1, n))**(n-1), 1)
+
+    assert_eq(Fraction(Mod(2, n), 1)**n, 2)
+    assert_eq(Fraction(Mod(2, n), 1)**(n-1), 1)
+
+    assert_eq(Fraction(Mod(2, n), 1.rat)**n, 2)
+    assert_eq(Fraction(Mod(2, n), 1.rat)**(n-1), 1)
+}
+
 say "** Test passed!"