Don't send update request if updatemask is empty for resources with t…

…erraform_labels field (GoogleCloudPlatform#9154)

* Don't send update request if updatmask is empty when resource has terraform_labels

* Remove the function check field_specific_update_methods

* Set project to billing project for google_network_security_address_group

* Change back of project for resource google_network_security_address_group

mmv1/products/networksecurity/AddressGroup.yaml

@@ -26,8 +26,28 @@ references:
   guides:
     "Use AddressGroups": "https://cloud.google.com/vpc/docs/use-address-groups-firewall-policies"
   api: "https://cloud.google.com/traffic-director/docs/reference/network-security/rest/v1beta1/organizations.locations.addressGroups"
-# Prevent the operation from being generated so we can call the custom one.
-autogen_async: false
+autogen_async: true
+async: !ruby/object:Api::OpAsync
+  operation: !ruby/object:Api::OpAsync::Operation
+    path: 'name'
+    base_url: '{{op_id}}'
+    wait_ms: 1000
+    timeouts: !ruby/object:Api::Timeouts
+      insert_minutes: 20
+      update_minutes: 20
+      delete_minutes: 20
+  result: !ruby/object:Api::OpAsync::Result
+    path: 'response'
+  status: !ruby/object:Api::OpAsync::Status
+    path: 'done'
+    complete: true
+    allowed:
+      - true
+      - false
+  error: !ruby/object:Api::OpAsync::Error
+    path: 'error'
+    message: 'message'
+  include_project: true
 import_format: ["{{%parent}}/locations/{{location}}/addressGroups/{{name}}"]
 examples:
   - !ruby/object:Provider::Terraform::Examples
@@ -53,9 +73,9 @@ examples:
       project: :PROJECT_NAME
 custom_code:
   !ruby/object:Provider::Terraform::CustomCode  # Calling custom operation that are different from other network security resources.
-  post_create: templates/terraform/post_create/network_security_address_group_operation.go.erb
-  post_update: templates/terraform/post_update/network_security_address_group_operation.go.erb
-  post_delete: templates/terraform/post_delete/network_security_address_group_operation.go.erb
+  pre_create: templates/terraform/pre_create/network_security_address_group_operation.go.erb
+  pre_update: templates/terraform/pre_update/network_security_address_group_operation.go.erb
+  pre_delete: templates/terraform/pre_delete/network_security_address_group_operation.go.erb
 parameters:
   - !ruby/object:Api::Type::String
     name: parent

mmv1/templates/terraform/post_update/cloudbuild_bitbucketserver_config.go.erb

@@ -21,7 +21,7 @@ if d.HasChange("connected_repositories") {
 	for _, repo := range removeRepos {
 		obj := make(map[string]interface{})
 		obj["connectedRepository"] = repo
-		res, err = transport_tpg.SendRequest(transport_tpg.SendRequestOptions{
+		_, err = transport_tpg.SendRequest(transport_tpg.SendRequestOptions{
 			Config: config,
 			Method: "POST",
 			Project: billingProject,
@@ -61,7 +61,7 @@ if d.HasChange("connected_repositories") {
 			return err
 		}
 
-		res, err = transport_tpg.SendRequest(transport_tpg.SendRequestOptions{
+		res, err := transport_tpg.SendRequest(transport_tpg.SendRequestOptions{
 			Config: config,
 			Method: "POST",
 			Project: billingProject,

mmv1/templates/terraform/pre_create/network_security_address_group_operation.go.erb

@@ -0,0 +1 @@
+project = ""

mmv1/templates/terraform/pre_delete/network_security_address_group_operation.go.erb

@@ -0,0 +1 @@
+project = ""

mmv1/templates/terraform/pre_update/network_security_address_group_operation.go.erb

@@ -0,0 +1 @@
+project = ""

mmv1/templates/terraform/resource.erb

@@ -792,7 +792,7 @@ func resource<%= resource_name -%>Update(d *schema.ResourceData, meta interface{
       billingProject = bp
     }
 
-<%      if object.update_mask && field_specific_update_methods(object.root_properties) -%>
+<%      if object.update_mask -%>
 // if updateMask is empty we are not updating anything so skip the post
 if len(updateMask) > 0 {
 <%      end -%>
@@ -838,7 +838,7 @@ if len(updateMask) > 0 {
     }
 <%        end -%>
 <%      end -%>
-<%      if object.update_mask && field_specific_update_methods(object.root_properties) -%>
+<%      if object.update_mask -%>
   }
 <%      end -%>
 <%    end # if !object.immutable -%>

mmv1/third_party/terraform/services/pubsub/resource_pubsub_topic_test.go

@@ -103,6 +103,43 @@ func TestAccPubsubTopic_schema(t *testing.T) {
 	})
 }
 
+func TestAccPubsubTopic_migration(t *testing.T) {
+	acctest.SkipIfVcr(t)
+	t.Parallel()
+
+	topic := fmt.Sprintf("tf-test-topic-%s", acctest.RandString(t, 10))
+
+	oldVersion := map[string]resource.ExternalProvider{
+		"google": {
+			VersionConstraint: "4.84.0", // a version that doesn't separate user defined labels and system labels
+			Source:            "registry.terraform.io/hashicorp/google",
+		},
+	}
+
+	acctest.VcrTest(t, resource.TestCase{
+		PreCheck:     func() { acctest.AccTestPreCheck(t) },
+		CheckDestroy: testAccCheckPubsubTopicDestroyProducer(t),
+		Steps: []resource.TestStep{
+			{
+				Config:            testAccPubsubTopic_update(topic, "foo", "bar"),
+				ExternalProviders: oldVersion,
+			},
+			{
+				Config:                   testAccPubsubTopic_update(topic, "foo", "bar"),
+				ProtoV5ProviderFactories: acctest.ProtoV5ProviderFactories(t),
+			},
+			{
+				ResourceName:             "google_pubsub_topic.foo",
+				ProtoV5ProviderFactories: acctest.ProtoV5ProviderFactories(t),
+				ImportStateId:            topic,
+				ImportState:              true,
+				ImportStateVerify:        true,
+				ImportStateVerifyIgnore:  []string{"labels", "terraform_labels"},
+			},
+		},
+	})
+}
+
 func testAccPubsubTopic_update(topic, key, value string) string {
 	return fmt.Sprintf(`
 resource "google_pubsub_topic" "foo" {