Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use byebug on MRI 2.0 and up #265

Merged
merged 1 commit into from
Jul 15, 2014
Merged

Use byebug on MRI 2.0 and up #265

merged 1 commit into from
Jul 15, 2014

Conversation

mvz
Copy link
Collaborator

@mvz mvz commented Jun 27, 2014

Debugger is not supported on 2.x. See cldwalker/debugger#125.

Another option is debugger2.

@mvz
Copy link
Collaborator Author

mvz commented Jun 27, 2014

Hm .. we should probably require byebug in spec_helper as well.

@@ -4,7 +4,8 @@ source 'https://rubygems.org'
gemspec

group :local_development do
gem 'debugger', platforms: [:ruby]
gem 'debugger', :platforms => :mri_19
gem 'byebug', :platforms => [:mri_20, :mri_21]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we specify >= :mri_20 to prevent future breakage on 2.2.x ?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately, you can't specify dependencies like that in bundler.

@gilles-leblanc
Copy link
Contributor

I have tested on my machine with bundle install and then running the tests. Using ruby 2.1.2. Everything is ok.

I had one question about the mri version otherwise everything is ok.

@mvz
Copy link
Collaborator Author

mvz commented Jul 1, 2014

Is anyone using the debugger? I always just use pry. Perhaps someone who has used either debugger or byebug can comment.

@troessner
Copy link
Owner

Is anyone using the debugger? I always just use pry.

Same here. Merged.

troessner added a commit that referenced this pull request Jul 15, 2014
@troessner troessner merged commit 8a0bc0a into master Jul 15, 2014
@troessner troessner deleted the use-byebug-on-ruby-2 branch July 15, 2014 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants