Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pressing Ctrl+C when searching sends SIGINT after next command #31

Closed
abitmore opened this issue May 8, 2019 · 1 comment · Fixed by #32
Closed

Pressing Ctrl+C when searching sends SIGINT after next command #31

abitmore opened this issue May 8, 2019 · 1 comment · Fixed by #32

Comments

@abitmore
Copy link
Contributor

abitmore commented May 8, 2019

Steps to reproduce:

  1. type anything in input mode, then press ctrl+R, enter search mode
  2. type anything, press ctrl+C
  3. type a command, press ENTER
  4. result: the program got a SIGINT, which is unexpected IMHO.

Maybe this change can fix it?2b75e9e#diff-532aa92b0f7db9561ed48bb41ec87506R694
troglobit added a commit that referenced this issue May 8, 2019
@troglobit
Fi #31: Aborting i-search with Ctrl-C should not generate signal
e2c3b41 
Signed-off-by: Joachim Nilsson <troglobit@gmail.com>
@troglobit
Copy link
Owner

We can escape recording Ctrl-C when searching, that's easier and we now behave more like GNU Readline. Thanks for reporting this!

troglobit added a commit that referenced this issue May 8, 2019
@troglobit
Revert "Fi #31: Aborting i-search with Ctrl-C should not generate sig…
c2b6564 
…nal"

This reverts commit e2c3b41.
This was referenced May 8, 2019
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Cleanup el_intr_pending in h_search_end() abitmore/editline
2 participants
@troglobit @abitmore