service.c: create conditions according to runtask exit status #232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In commit f0f358a: [ service.c: set/clear condition 'done' for run tasks ] a runtask done condition would be set/cleared when entering DONE/HALTED states, but it did not cover all the user cases, for instance, sometimes an end user may want to know if a runtask has finished sucessfully or to decide what to do on its failures. So we now change the conditions to: tsktype/tskname/success and tsktype/tskname/failure. And this change not only applies to run/task types, but also applies to sysv type, in case it fails, a sysv/tskname/failure condition would be set. Signed-off-by: Ming Liu <liu.ming50@gmail.com>
|
Nicely done. No comments from me on this one :-) (Sorry for taking so long to respond! In the middle of changing jobs) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In commit f0f358a:
[ service.c: set/clear condition 'done' for run tasks ]
a runtask done condition would be set/cleared when entering DONE/HALTED
states, but it did not cover all the user cases, for instance, sometimes
an end user may want to know if a runtask has finished sucessfully or
to decide what to do on its failures.
So we now change the conditions to: tsktype/tskname/success and
tsktype/tskname/failure.
And this change not only applies to run/task types, but also applies to
sysv type, in case it fails, a sysv/tskname/failure condition would be
set.
Signed-off-by: Ming Liu liu.ming50@gmail.com