Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

initctl.c: fix a return value of run tasks #233

Merged

Conversation

liuming50
Copy link
Contributor

When a run task is started with svc->started = 1, it should be
considered started successfully so it should return 0.

Signed-off-by: Ming Liu liu.ming50@gmail.com

@liuming50 liuming50 force-pushed the fix-a-return-value-of-initctl-status branch from 023ef19 to 7cb4e7a Compare March 3, 2022 15:51
src/svc.h Outdated Show resolved Hide resolved
src/service.c Outdated Show resolved Hide resolved
src/initctl.c Outdated Show resolved Hide resolved
When a run task is started with svc->started = 1, it should be
considered started successfully or failed on the other hand.

Signed-off-by: Sergio Morlans <sergio.morlans@atlascopco.com>
Signed-off-by: Ming Liu <liu.ming50@gmail.com>
@liuming50 liuming50 force-pushed the fix-a-return-value-of-initctl-status branch from 7cb4e7a to e1c59a2 Compare March 5, 2022 10:54
@liuming50
Copy link
Contributor Author

@troglobit Changes in patch set V2:

1 Changes combined to one commit.
2 Change the status string to 'done' as you suggested.

@troglobit
Copy link
Owner

Awesome, thank you! <3

@troglobit troglobit merged commit 11bc87e into troglobit:master Mar 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants