Add mysql secure connection function (closes #277) #281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wongsyrone
reviewed
Feb 29, 2020
wongsyrone
reviewed
Feb 29, 2020
wongsyrone
reviewed
Feb 29, 2020
|
Thanks! I'll review soon. |
Chigusa0w0
reviewed
Mar 4, 2020
GreaterFire
requested changes
Mar 13, 2020
There was a problem hiding this comment.
IMO, we don't need the tls_version field as it can be configured elsewhere (https://dev.mysql.com/doc/refman/8.0/en/encrypted-connection-protocols-ciphers.html).
Generally LGTM. Just a bit of comments.
Could you test these changes?
GreaterFire
changed the title
commit 2be23c8 Author: memorz <chenyanbo@bipt.edu.cn> Date: Sat Mar 14 23:11:24 2020 +0800 Update src/core/authenticator.cpp Co-Authored-By: GreaterFire <32649575+GreaterFire@users.noreply.github.com> commit 1e11110 Author: memorz <chenyanbo@bipt.edu.cn> Date: Sat Mar 14 23:10:36 2020 +0800 Update docs/authenticator.md good Co-Authored-By: GreaterFire <32649575+GreaterFire@users.noreply.github.com> commit 17a8549 Author: memorz <chenyanbo@bipt.edu.cn> Date: Wed Mar 4 15:12:44 2020 +0800 Update authenticator.cpp commit ec1bd60 Author: memorz <chenyanbo@bipt.edu.cn> Date: Sat Feb 29 20:56:47 2020 +0800 Update src/core/config.cpp good Co-Authored-By: Syrone Wong <wong.syrone@gmail.com> commit 332fb53 Author: memorz <chenyanbo@bipt.edu.cn> Date: Sat Feb 29 20:56:31 2020 +0800 Update src/core/authenticator.cpp good Co-Authored-By: Syrone Wong <wong.syrone@gmail.com> commit 20c206a Author: memorz <chenyanbo@bipt.edu.cn> Date: Sat Feb 29 14:58:47 2020 +0800 add config options description add config options description about secure connect to mysql commit 376a597 Author: memorz <chenyanbo@bipt.edu.cn> Date: Sat Feb 29 14:53:37 2020 +0800 read the config about secure connect to mysql read the config about secure connect to mysql commit 718aeb8 Author: memorz <chenyanbo@bipt.edu.cn> Date: Sat Feb 29 14:52:14 2020 +0800 add some head about secure connect add some head about secure connect commit b3a26ac Author: memorz <chenyanbo@bipt.edu.cn> Date: Sat Feb 29 14:50:14 2020 +0800 add secure connect(TLS) to mysql add secure connect(TLS) to mysql commit 9a048e4 Author: memorz <chenyanbo@bipt.edu.cn> Date: Sat Feb 29 14:46:44 2020 +0800 add config description add config description commit 9264b26 Author: memorz <chenyanbo@bipt.edu.cn> Date: Sat Feb 29 14:44:21 2020 +0800 add mysql secure connect config options add mysql secure connect config options
ghost
mentioned this pull request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add mysql secure connection function