New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rework test without suspense #1

Open

ertrzyiks wants to merge 1 commit into trojanowski:master from ertrzyiks:get-rid-of-suspense

ertrzyiks commented May 15, 2019 •

edited

Loading

Since trojanowski/react-apollo-hooks#80 suspense is disabled by default, I thought it would make sense to have an example without it.

Changes here:

update react-apollo-hooks
remove <Suspense> wrapper
use loading value to render a placeholder

The lock file diff is huge, here is my local env information:

$ npm -v
5.6.0
$ node -v
v8.10.0


          Rework test without suspense

9fca004

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet