Merge pull request #170 from hckrnews/feature/fix-custom-type-validation

Fix the custom type error validation
trojs · Apr 16, 2021 · e09bfc8 · e09bfc8
2 parents 57554e8 + 0b8c695
commit e09bfc8
Show file tree

Hide file tree

Showing 4 changed files with 37 additions and 25 deletions.
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
     "name": "@hckrnews/validator",
-    "version": "4.2.2",
+    "version": "4.2.3",
     "description": "Object validator",
     "main": "src/validator.js",
     "files": [

diff --git a/src/validator.js b/src/validator.js
@@ -106,7 +106,9 @@ class Validator {
         if (!(fieldType in types)) {
             const validationMethod = `validate${value.constructor.name}`;
 
-            return this[validationMethod](value, fieldType);
+            return this[validationMethod]
+                ? this[validationMethod](value, fieldType)
+                : false;
         }
 
         const type = types[fieldType];

diff --git a/tests/unit/validator.spec.js b/tests/unit/validator.spec.js
@@ -11,7 +11,7 @@ const test2 = new Test2('me');
 
 const testCases = [
     {
-        description: 'A valid test',
+        description: 'A valid test with a custom type',
         input: {
             name: 'test',
             test: test2,
@@ -20,6 +20,16 @@ const testCases = [
         expectedValue: true,
         expectedErrors: [],
     },
+    {
+        description: 'A invalid test with a custom type',
+        input: {
+            name: 'test',
+            test: 'test',
+        },
+        schema: test1Schema,
+        expectedValue: false,
+        expectedErrors: [['test', Test2]],
+    },
     {
         description: 'A valid bar',
         input: {