-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding L2GW support for SRIOV scenario #118
base: stable/danube
Are you sure you want to change the base?
Conversation
NeutronSupportedPCIVendorDevs: ['8086:10ed','8086:10fb'] | ||
NeutronPhysicalDevMappings: "physnet1:em2" | ||
# Number of VFs that needs to be configured for a physical interface | ||
NeutronSriovNumVFs: "em2:8" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
shouldn't this be a per deployment setting? since nic names can change based on deployment
# Number of VFs that needs to be configured for a physical interface | ||
NeutronSriovNumVFs: "em2:8" | ||
NovaPCIPassthrough: | ||
- devname: "em2" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should this have spaces in front of it if it is a list of values for NovaPCIPassthrough?
NeutronSriovNumVFs: "em2:8" | ||
NovaPCIPassthrough: | ||
- devname: "em2" | ||
physical_network: "physnet1" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should this have '-' if it part of the list for NovaPCIPassthrough?
NeutronTenantNetworkType: vlan | ||
NeutronNetworkVLANRanges: physnet1:3001:3009 | ||
ExtraConfig: | ||
neutron::server::service_providers: [ 'L2GW:OpenDaylight:networking_odl.l2gateway.driver.OpenDaylightL2gwDriver:default' ] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this needs spaces in front of it as well
After talking to Feng, we will let the user choose the interface in the scenario description using the parameter sriov_iface, and it will update opnfv-environment.yaml file to overwrite the commented parameters related to that interface name. |
neutron::server::service_providers: [ 'L2GW:OpenDaylight:networking_odl.l2gateway.driver.OpenDaylightL2gwDriver:default' ] | ||
|
||
#enable DHCP on ODL | ||
opendaylight::enable_dhcp: true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this line meant to be in ExtraConfig section? Also, why is it set here?
NeutronMechanismDrivers: ['sriovnicswitch','openvswitch','opendaylight_v2'] | ||
NeutronServicePlugins: "odl-router_v2,networking-l2gw" | ||
NeutronNetworkType: 'vxlan' | ||
NeutronTenantNetworkType: vlan |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I dont see NeutronTenantNetworkType defined in our tht. I do see NeutronNetworkType, which is the tenant network type. That should be VLAN right? and remove line 16?
No description provided.