Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

client: remove internal info #103

Merged
merged 3 commits into from
Oct 18, 2023

Conversation

Lichas
Copy link
Contributor

@Lichas Lichas commented Oct 18, 2023

  • remove some internal info, such as: cmlb, tjg, ons
  • modify typo "schema" to "scheme"

@codecov
Copy link

codecov bot commented Oct 18, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (987623a) 85.59% compared to head (b12785f) 85.75%.
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #103      +/-   ##
==========================================
+ Coverage   85.59%   85.75%   +0.15%     
==========================================
  Files         188      188              
  Lines       16114    16114              
==========================================
+ Hits        13793    13818      +25     
+ Misses       1758     1737      -21     
+ Partials      563      559       -4     
Flag Coverage Δ
unittests 85.75% <ø> (+0.15%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
client/options.go 88.45% <ø> (ø)
naming/selector/selector.go 100.00% <ø> (ø)

... and 183 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@sandyskies sandyskies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sandyskies sandyskies merged commit ee02522 into trpc-group:main Oct 18, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Oct 18, 2023
@Lichas Lichas deleted the feat/remove_legacy_info branch October 19, 2023 07:16
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants