Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix label name in 03-proposal.md and add question issue template #125

Merged
merged 2 commits into from
Oct 27, 2023

Conversation

longyue0521
Copy link
Contributor

@longyue0521 longyue0521 commented Oct 26, 2023

@WineChord

  1. 需要有权限的小伙伴添加proposal标签
  2. 添加question issue模版,自动打question标签

Signed-off-by: longyue0521 <longyueli0521@gmail.com>
@github-actions
Copy link

github-actions bot commented Oct 26, 2023

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@longyue0521
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

liuzengh added a commit to trpc-group/cla-database that referenced this pull request Oct 26, 2023
@codecov
Copy link

codecov bot commented Oct 26, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (1536955) 85.54052% compared to head (3be522d) 85.60879%.

Additional details and impacted files
@@                 Coverage Diff                 @@
##                main        #125         +/-   ##
===================================================
+ Coverage   85.54052%   85.60879%   +0.06826%     
===================================================
  Files            188         188                 
  Lines          16114       16114                 
===================================================
+ Hits           13784       13795         +11     
+ Misses          1771        1756         -15     
- Partials         559         563          +4     
Flag Coverage Δ
unittests 85.60879% <ø> (+0.06826%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: longyue0521 <longyueli0521@gmail.com>
Copy link
Contributor

@liuzengh liuzengh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

The proposal label has been added.

@liuzengh liuzengh self-requested a review October 27, 2023 02:36
name: Questions
about: questions or inquiries about the project
title: "question: affected/package: "
labels: question
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suddenly realized that the default question label on GitHub actually refers to the issue being in an "in question" state, rather than indicating that the issue is a question raised by a user.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"in question": the matter in question: at issue, being discussed, under discussion, under consideration, on the agenda, for debate, to be discussed, to be decided.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

question | Indicates that an issue, pull request, or discussion needs more information

这个描述很宽泛,已经将用户提出的问题这个含义包含在内了

@sandyskies sandyskies merged commit bb1f48a into trpc-group:main Oct 27, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Oct 27, 2023
@longyue0521 longyue0521 deleted the add_question_issue_template branch October 27, 2023 09:26
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants