Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use errors.New instead of fmt.Errorf #127

Merged
merged 2 commits into from
Oct 30, 2023
Merged

Conversation

chenyahui
Copy link
Contributor

@chenyahui chenyahui commented Oct 27, 2023

I have read the CLA Document and I hereby sign the CLA

@github-actions
Copy link

github-actions bot commented Oct 27, 2023

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@trpc-group trpc-group deleted a comment from chenyahui Oct 27, 2023
http/transport.go Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Oct 27, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (1536955) 85.54052% compared to head (a76e72a) 85.55294%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@                 Coverage Diff                 @@
##                main        #127         +/-   ##
===================================================
+ Coverage   85.54052%   85.55294%   +0.01242%     
===================================================
  Files            188         188                 
  Lines          16114       16114                 
===================================================
+ Hits           13784       13786          +2     
+ Misses          1771        1763          -8     
- Partials         559         565          +6     
Flag Coverage Δ
unittests 85.55294% <0.00000%> (+0.01242%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
http/transport.go 83.42697% <0.00000%> (ø)
log/log.go 89.93711% <0.00000%> (ø)

... and 6 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@liuzengh
Copy link
Contributor

I have read the CLA Document and I hereby sign the CLA

CLA check doesn't seem to be working properly. Could you post a new comment? @chenyahui

Co-authored-by: wineandchord <guoqizhou123123@qq.com>
Copy link
Contributor

@WineChord WineChord left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chenyahui
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

liuzengh added a commit to trpc-group/cla-database that referenced this pull request Oct 27, 2023
@sandyskies sandyskies merged commit 369c60d into trpc-group:main Oct 30, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Oct 30, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants