Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

http: improve stability of http test #168

Merged
merged 3 commits into from
Apr 16, 2024
Merged

Conversation

WineChord
Copy link
Contributor

Fixes #

https://github.com/trpc-group/trpc-go/actions/runs/8682142411/job/23806165703?pr=167

image

TestHTTPGotConnectionRemoteAddr will occasionally fail because TestCheckRedirect does not restore the modification of CheckRedirect.

RELEASE NOTES: NONE

Copy link
Contributor

@sandyskies sandyskies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sandyskies sandyskies merged commit 82f4e4a into trpc-group:main Apr 16, 2024
11 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Apr 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants