fix: Handle WebSocket errors to avoid Node.js crashes #2522
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
jlalmes
previously approved these changes
Aug 24, 2022
sachinraja
previously approved these changes
Aug 24, 2022
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
cc @frol I've updated it to use |
…to fix/handle-websocket-errors
jlalmes
approved these changes
Aug 24, 2022
sachinraja
approved these changes
Aug 24, 2022
KATT
approved these changes
Aug 24, 2022
|
That makes total sense, thanks for updating and merging the PR! 🎉 |
|
This pull request has been locked because it had no new activity for 30 days. If you think, this PR is still necessary, create a new one with the same branch. Thank you. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎯 Changes
We caught the following error on our production:
I believe those malformed requests come from some vulnerability scanners. In either case, such requests should not crash the instance. During the investigation I found this discussion: websockets/ws#1354 (comment), and started to look into the way of handling the error. It seems there is no other way to inject this handler, so here is the PR. I have tested it already and it prevents the crash of the nodejs process.
✅ Checklist