Intent url fix

[elpaxel]

Fix opening intent:// url from javascript and by left click.

[truefedex]

@elpaxel please explain why this is needed. Can you tell me where the intent:// URLs is used? And why open them through onOpenInExternalAppRequested if askUserAndOpenInExternalApp is used further in the code? Your code will automatically open the external application, but other TVbro users have complained about this behavior, so a permission request from the user has been added.

[elpaxel]

So right now if I'm doing this on the page:

location.href = "intent://some_video_url.m3u8#Intent;action=android.intent.VIEW;scheme=https;type=video/*;S.subtitles_location=/some_subtitles.vtt;end";

then TVbro says there is no app for this type of url.

I have used "onOpenInExternalAppRequested" because there is "Intent.parseUri(url, Intent.URI_INTENT_SCHEME)". I guess this way my url parsed correctly and "subtitles_location" that I use for VLC will be in place. Second reason because that function is the old version of intent handling I guess (old fix).

As for the code further in and "askUserAndOpenInExternalApp", it uses "Intent(Intent.ACTION_VIEW, uri)". I guess it creates new Intent with ACTION_VIEW and expects "plain" url. Something like "intent://some_video_url.m3u8". But this way (again I guess) "subtitles_location" will be stripped. I have made this assumptions by reading code because as of now it is failing there.

It is working fine with my fix but my reflections may be wrong because I don't use Kotlin and didn't read your code too deeply.

[elpaxel]

So I have changed this:
val intent = Intent(Intent.ACTION_VIEW, uri)
to this:
val intent = Intent.parseUri(url, Intent.URI_INTENT_SCHEME)
and everything working fine.

This edit based on this docs.

When used with parseUri(String, int), any other scheme will result in a generic VIEW action for that raw URI.

So the code flow remains the same.

Links tested to work:
intent://some_video_url.m3u8#Intent;action=android.intent.VIEW;scheme=https;type=video/*;S.subtitles_location=/some_subtitles.vtt;end
https://some_video_url.m3u8
magnet:?xt=urn:btih:some_hash

But this way there is permission popup appearing every time. A little bit annoying.
I think it is better to not trigger permission popup when you specifically using intent:// scheme.

[truefedex]

@elpaxel Thank you for explanations. I think may be I will change a bit this behaviour later.