fix lint workflow #300
Maanas-23lint-and-test.yaml
on: pull_request
detect-modules
10s
Matrix: golangci-lint
Annotations
10 errors and 4 warnings
|
golangci-lint (/home/runner/work/elasti/elasti/pkg):
pkg/logger/logger.go#L68
missing cases in switch of type zapcore.FieldType: zapcore.UnknownType, zapcore.ArrayMarshalerType, zapcore.ObjectMarshalerType, zapcore.BinaryType, zapcore.BoolType, zapcore.ByteStringType, zapcore.Complex128Type, zapcore.Complex64Type, zapcore.DurationType, zapcore.Float64Type, zapcore.Float32Type, zapcore.TimeType, zapcore.TimeFullType, zapcore.Uint64Type, zapcore.Uint32Type, zapcore.Uint16Type, zapcore.Uint8Type, zapcore.UintptrType, zapcore.ReflectType, zapcore.NamespaceType, zapcore.StringerType, zapcore.SkipType, zapcore.InlineMarshalerType (exhaustive)
|
|
golangci-lint (/home/runner/work/elasti/elasti/pkg):
pkg/scaling/scalers/prometheus_scaler.go#L40
NewPrometheusScaler returns interface (github.com/truefoundry/elasti/pkg/scaling/scalers.Scaler) (ireturn)
|
|
golangci-lint (/home/runner/work/elasti/elasti/pkg):
pkg/scaling/scale_handler.go#L243
createScalerForTrigger returns interface (github.com/truefoundry/elasti/pkg/scaling/scalers.Scaler) (ireturn)
|
|
golangci-lint (/home/runner/work/elasti/elasti/pkg):
pkg/logger/logger.go#L111
error returned from interface method should be wrapped: sig: func (go.uber.org/zap/zapcore.Core).Write(go.uber.org/zap/zapcore.Entry, []go.uber.org/zap/zapcore.Field) error (wrapcheck)
|
|
golangci-lint (/home/runner/work/elasti/elasti/pkg):
pkg/scaling/scale_handler.go#L255
error returned from external package is unwrapped: sig: func github.com/truefoundry/elasti/pkg/scaling/scalers.NewPrometheusScaler(metadata any) (github.com/truefoundry/elasti/pkg/scaling/scalers.Scaler, error) (wrapcheck)
|
|
golangci-lint (/home/runner/work/elasti/elasti/pkg)
issues found
|
|
golangci-lint (/home/runner/work/elasti/elasti/operator)
The job was canceled because "_home_runner_work_elast_2" failed.
|
|
golangci-lint (/home/runner/work/elasti/elasti/operator)
The operation was canceled.
|
|
golangci-lint (/home/runner/work/elasti/elasti/resolver)
The job was canceled because "_home_runner_work_elast_2" failed.
|
|
golangci-lint (/home/runner/work/elasti/elasti/resolver)
The operation was canceled.
|
|
detect-modules
Restore cache failed: Dependencies file is not found in /home/runner/work/elasti/elasti. Supported file pattern: go.sum
|
|
golangci-lint (/home/runner/work/elasti/elasti/pkg)
Restore cache failed: Dependencies file is not found in /home/runner/work/elasti/elasti. Supported file pattern: go.sum
|
|
golangci-lint (/home/runner/work/elasti/elasti/operator)
Restore cache failed: Dependencies file is not found in /home/runner/work/elasti/elasti. Supported file pattern: go.sum
|
|
golangci-lint (/home/runner/work/elasti/elasti/resolver)
Restore cache failed: Dependencies file is not found in /home/runner/work/elasti/elasti. Supported file pattern: go.sum
|