Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add nextcloud #96

Merged
merged 27 commits into from
Aug 7, 2024
Merged

Add nextcloud #96

merged 27 commits into from
Aug 7, 2024

Conversation

stavros-k
Copy link
Contributor

@stavros-k stavros-k commented Aug 2, 2024

Additionally fixes truenas/charts#2123

Instead of having to install packages during runtime of the container, we do that now before the container even starts.
A hash of the inlined dockerfile is used to ensure that any change will cause a rebuild of the image.
Additionally, if the hashed image is already present on the host, the cached image will be re-used.

@stavros-k stavros-k changed the base branch from master to lib-sync August 2, 2024 17:17
Base automatically changed from lib-sync to master August 5, 2024 11:59
@stavros-k stavros-k force-pushed the add-nextcloud branch 3 times, most recently from d2583dc to c4bb98b Compare August 6, 2024 13:43
@stavros-k stavros-k marked this pull request as ready for review August 6, 2024 13:45
@stavros-k stavros-k requested a review from Qubad786 August 6, 2024 13:48
Copy link
Contributor

@Qubad786 Qubad786 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work 👏

@stavros-k stavros-k merged commit 6483a29 into master Aug 7, 2024
6 checks passed
@stavros-k stavros-k deleted the add-nextcloud branch August 7, 2024 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Nextcloud: Weird smb behavior, potentially missing php module
2 participants