Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PD-1296 / 24.10 / PD-1296-review-ui-images-for-electric-eel #3187

Merged
merged 3 commits into from
Nov 8, 2024

Conversation

linzi-ix
Copy link
Contributor

@linzi-ix linzi-ix commented Nov 5, 2024

Thanks for contributing to TrueNAS documentation! By opening a Pull Request, you're acknowledging that your changes will be distributed under the Creative Commons 4.0 license.

@linzi-ix linzi-ix requested a review from a team as a code owner November 5, 2024 13:48
@bugclerk bugclerk changed the title PD-1296-review-ui-images-for-electric-eel PD-1296 / 24.10 / PD-1296-review-ui-images-for-electric-eel Nov 5, 2024
@bugclerk
Copy link
Contributor

bugclerk commented Nov 5, 2024

@micjohnson777 micjohnson777 added the Technical Writer Review (MJ) A technical writer is reviewing the PR. label Nov 7, 2024
Copy link
Contributor

@micjohnson777 micjohnson777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The images that replace the services that show what service it is like the one for SMARTSystemServicesSCALE.md need to actually include the service.
The one that replaces DevicesExtend.png is way too large. Can you resize the window and retake this screenshot.

DjP-iX
DjP-iX previously approved these changes Nov 8, 2024
@DjP-iX DjP-iX merged commit 08a9afa into 24.10 Nov 8, 2024
3 checks passed
@DjP-iX DjP-iX deleted the PD-1296-review-ui-images-for-electric-eel branch November 8, 2024 13:53
@bugclerk
Copy link
Contributor

bugclerk commented Nov 8, 2024

This PR has been merged and conversations have been locked.
If you would like to discuss more about this issue please use our forums or raise a Jira ticket.

@truenas truenas locked as resolved and limited conversation to collaborators Nov 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Re-Review Technical Writer Review (MJ) A technical writer is reviewing the PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants