NAS-129639 / 25.04 / Remove unused API endpoints #14576
Conversation
bugclerk
changed the title
themylogin
force-pushed
the
NAS-129639
branch
3 times, most recently
from
94f45bf
to
856dcd3
Compare
| @@ -47,17 +47,6 @@ async def ec_curve_choices(self): | |||
| """ | |||
| return {k: k for k in EC_CURVES} | |||
|
|
|||
| @accepts() | |||
There was a problem hiding this comment.
Are we certain UI is not using these ?
There was a problem hiding this comment.
Yes, no removed endpoints are used by the UI. @undsoft are those just hardcoded?
There was a problem hiding this comment.
Yes, this is hardcoded. We can call an endpoint if we feel like that would be beneficial.
| *[Dict(profile, additional_attrs=True) for profile in CSR_PROFILES], | ||
| example=CSR_PROFILES, | ||
| )) | ||
| async def certificate_signing_requests_profiles(self): |
There was a problem hiding this comment.
UI should be using this for CSR profiles, seems like they are using the wrong endpoint atm
There was a problem hiding this comment.
@undsoft it is strange that the UI does not use this
There was a problem hiding this comment.
We call webui.crypto.certificate_profiles.
There was a problem hiding this comment.
That is not accurate and UI should be using this endpoint instead, i'll make a ticket
There was a problem hiding this comment.
There was a problem hiding this comment.
We missed specifying CSR profiles in that ticket, created a ticket for that https://ixsystems.atlassian.net/browse/NAS-131460
There was a problem hiding this comment.
Please rename that function and also put it under webui namespace. webui.crypto.csr_profiles
| @@ -9,22 +8,6 @@ class Config: | |||
| namespace = 'system.advanced' | |||
| cli_namespace = 'system.advanced' | |||
|
|
|||
| @accepts(roles=['SYSTEM_ADVANCED_READ']) | |||
| @returns(Dict(additional_attrs=True)) | |||
| def get_gpu_pci_choices(self): | |||
There was a problem hiding this comment.
This is being used by UI as well iirc, @Qubad786 can you confirm ?
There was a problem hiding this comment.
It seems UI is using device.get_info right now but it should be using this endpoint instead and i think we already have a ticket for UI to use this endpoint
There was a problem hiding this comment.
|
This PR has been merged and conversations have been locked. |
|
time 20:00 |
|
Time tracking added. |
No description provided.