-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated code for Device creation for nvme drives following smartmontools update #76
Conversation
This PR --as is-- breaks retrocompatibility. |
Yep, realised the new regex will break the old one. I'll modify the code so it stays backwards compatible with older versions. What new tests should I add? I'm not sure how to replicate the new output from the new version of smartmontools. |
I've issues explaining how to add tests, so don't worry about that yet. |
Got it, will work on the code in a separate branch until the tests pass so I stop triggering reruns of the tests. |
after some issues with gh tool, i've pushed f76917d to your branch. It should have a test for the new 7.4 version. |
As the tests are currently, the There are basically two options here, either modify the old tests to report |
Thank you @NicholasCJL ! Yeah, setting the seg = null is the correct way, as is a new field that would be in any nvme tests from now on. |
Fixed regex for this issue #75 for smartmontools release 7.4
Also updated
testentry.py
anddevice.py
to capture and show new output format for nvme self-test logs.