Skip to content

Commit

Permalink
Boost maximum valid pwrite range to 64 TiB (#436)
Browse files Browse the repository at this point in the history
Packet captures from Windows server shows that writes to large
offsets / large files is permitted over SMB protocol to ReFS
backed SMB shares and so we should do the same.
  • Loading branch information
anodos325 authored Nov 20, 2024
1 parent a716890 commit 59d913e
Showing 1 changed file with 6 additions and 1 deletion.
7 changes: 6 additions & 1 deletion source3/smbd/vfs.c
Original file line number Diff line number Diff line change
Expand Up @@ -427,8 +427,13 @@ bool vfs_valid_pwrite_range(off_t offset, size_t length)
{
/*
* See MAXFILESIZE in [MS-FSA] 2.1.5.3 Server Requests a Write
*
* Packet captures on ReFS showed successful writes to offsets
* greater than MAXFILESIZE in MS-FSA and so we boost this to
* 64 TiB which seems like a reasonable upper-bound for VEEAM
* workloads.
*/
static const uint64_t maxfilesize = 0xfffffff0000;
static const uint64_t maxfilesize = 0x0000400000000000;
uint64_t last_byte_ofs;
bool ok;

Expand Down

0 comments on commit 59d913e

Please sign in to comment.