NAS-126731 / 24.04-RC.1 / Disable unused expensive code in addVirtualTarget (by bmeagherix) #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yocalebo
changed the title
bugclerk
force-pushed
the
NAS-126731-24.04-RC.1
branch
from
49b7ec7 to
04850d6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code to enable all hardware targets before creating virtual ones becomes more expensive as the target count climbs.
This change reduces the start time of 100 targets from ~30 seconds to around ~13. [Varies depending on platform, but approx 50% reduction seen everwhere.]
Original PR: #19
Jira URL: https://ixsystems.atlassian.net/browse/NAS-126731