Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NAS-129309 / None / Add XCOPY support in blkdev handler #37

Merged
merged 1 commit into from
Dec 19, 2024
Merged

NAS-129309 / None / Add XCOPY support in blkdev handler #37

merged 1 commit into from
Dec 19, 2024

Conversation

ixhamza
Copy link

@ixhamza ixhamza commented Dec 18, 2024 •
edited
Loading

This PR introduces support for XCOPY in SCST.

Related Patches

How Has This Been Tested?

  • Tested using sg_xcopy from the client side and validate blocks are cloned correctly through zfs zdb.
  • Verified performance enhancement.
  • Scale Build & API Tests.

This was referenced Dec 18, 2024
Merged
Merged
@bugclerk bugclerk changed the title Add XCOPY support in blkdev handler NAS-129309 / None / Add XCOPY support in blkdev handler Dec 18, 2024
@bugclerk
Copy link

Jira URL: https://ixsystems.atlassian.net/browse/NAS-129309

bmeagherix
bmeagherix approved these changes Dec 18, 2024
View reviewed changes
Copy link

@bmeagherix bmeagherix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve (with comment. Your call as to whether worthwhile addressing.)

scst/src/dev_handlers/scst_vdisk.c Show resolved Hide resolved
@ixhamza ixhamza merged commit b7b523d into truenas-3.9.0-pre Dec 19, 2024
0 of 4 checks passed
@bugclerk
Copy link

Not updating JIRA ticket https://ixsystems.atlassian.net/browse/NAS-129309 target versions as no JIRA version corresponds to this PR

@bugclerk
Copy link

This PR has been merged and conversations have been locked.
If you would like to discuss more about this issue please use our forums or raise a Jira ticket.

@truenas truenas locked as resolved and limited conversation to collaborators Dec 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bmeagherix bmeagherix bmeagherix approved these changes

@usaleem-ix usaleem-ix usaleem-ix approved these changes

@amotin amotin amotin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ixhamza @bugclerk @amotin @usaleem-ix @bmeagherix