Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NAS-132527 / 25.04 / Rename some instances of websocket #11040

Merged
merged 1 commit into from
Nov 15, 2024
Merged

Conversation

undsoft
Copy link
Collaborator

@undsoft undsoft commented Nov 14, 2024

Changes:

Simply renames some instances of ws to api after service was renamed.

Testing:

Shallow code review.

@undsoft undsoft requested a review from a team as a code owner November 14, 2024 20:42
@undsoft undsoft requested review from RehanY147 and removed request for a team November 14, 2024 20:42
@bugclerk bugclerk changed the title NAS-132527: Rename some instances of websocket NAS-132527 / 25.04 / Rename some instances of websocket Nov 14, 2024
@bugclerk
Copy link
Contributor

Copy link

codecov bot commented Nov 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.82%. Comparing base (d9c19a7) to head (2d90e6e).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #11040      +/-   ##
==========================================
- Coverage   81.82%   81.82%   -0.01%     
==========================================
  Files        1622     1622              
  Lines       57369    57363       -6     
  Branches     5923     5923              
==========================================
- Hits        46944    46939       -5     
+ Misses      10425    10424       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@undsoft undsoft merged commit 663e7bc into master Nov 15, 2024
11 checks passed
@undsoft undsoft deleted the NAS-132527 branch November 15, 2024 08:46
@bugclerk
Copy link
Contributor

This PR has been merged and conversations have been locked.
If you would like to discuss more about this issue please use our forums or raise a Jira ticket.

@truenas truenas locked as resolved and limited conversation to collaborators Nov 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants