NAS-132648 / 25.04 / query param handling for auth tokens

[aervin]

Changes:

Testing:
One method:

• clear localStorage
• you'll have to comment out the https: check in AuthService.setQueryToken
• midclt call auth.generate_token
• append the token to an app route: localhost:4200/storage/disks?token=<token>

Downstream

Affects	Reasoning
Documentation

[bugclerk]

Jira URL: https://ixsystems.atlassian.net/browse/NAS-132648

[aervin]

The approach so far is to forward query params on redirect to /signin (AuthGuardService:canActivate). From there, add a bit of logic to signin.store and auth.service to handle the token.

However, this isn't working like I'd expect. Seems that WebsocketHandlerService is calling its resetUI method and interfering with the redirect.

[codecov]

Codecov Report

Attention: Patch coverage is 75.75758% with 8 lines in your changes missing coverage. Please review.

Project coverage is 82.45%. Comparing base (cf486c8) to head (748ebfc).
Report is 54 commits behind head on master.

✅ All tests successful. No failed tests found.

Files with missing lines	Patch %	Lines
src/app/core/guards/websocket-connection.guard.ts	0.00%	5 Missing ⚠️
src/app/pages/signin/store/signin.store.ts	84.21%	3 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master   #11080      +/-   ##
==========================================
+ Coverage   82.35%   82.45%   +0.10%     
==========================================
  Files        1630     1648      +18     
  Lines       57229    58008     +779     
  Branches     5915     5957      +42     
==========================================
+ Hits        47130    47833     +703     
- Misses      10099    10175      +76     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[undsoft]

Seems to be redirecting fine for me:

2024-11-21.11.03.57.mov

[undsoft]

BTW, I don't know if tokens in browser history is kosher.

[undsoft]

The code looks good, but I just couldn't get it to work on a CI machine.
I can see token being sent to middleware, but it just returns AUTH_ERR for some reason.

[aervin]

Went to retest against a CI machine and the hasOpened logic was already flaky/broken. As an alternative approach, I've manually preserved query params on redirect in the resetUi method.

Seems to work fine against a CI machine with both root and non-builtin users.

[undsoft]

I still get the same issue:

2024-12-03.11.13.03.mov

[bugclerk]

This PR has been merged and conversations have been locked.
If you would like to discuss more about this issue please use our forums or raise a Jira ticket.