Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NAS-132671 / 25.04 / Initial Containers Loading - Hide empty component until data is received #11100

Merged
merged 4 commits into from
Dec 4, 2024

Conversation

bvasilenko
Copy link
Contributor

Changes:

  • Show loader until we know the actual response.
  • Show empty component only if we don’t have instances.

Testing:

Ovserve the initial loading of the Containers page

@bvasilenko bvasilenko requested a review from a team as a code owner November 26, 2024 08:44
@bvasilenko bvasilenko requested review from RehanY147 and removed request for a team November 26, 2024 08:44
@bugclerk bugclerk changed the title NAS-132671: Initial Containers Loading - Hide empty component until data is received NAS-132671 / 25.04 / Initial Containers Loading - Hide empty component until data is received Nov 26, 2024
@bugclerk
Copy link
Contributor

Copy link

codecov bot commented Nov 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.39%. Comparing base (8c8c3c6) to head (3074fd7).
Report is 16 commits behind head on master.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #11100      +/-   ##
==========================================
+ Coverage   82.28%   82.39%   +0.10%     
==========================================
  Files        1650     1647       -3     
  Lines       57730    57870     +140     
  Branches     5948     5958      +10     
==========================================
+ Hits        47506    47682     +176     
+ Misses      10224    10188      -36     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@RehanY147 RehanY147 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Having a boolean just to identify when data is loaded doesn't feel like a good solution. Maybe instead, we can use undefined or null initially and then just check for a non-null value to identify if the data has been loaded at least once. Replacing undefined with [] for example, when the request has completed.

@bvasilenko bvasilenko merged commit f93e825 into master Dec 4, 2024
9 checks passed
@bvasilenko bvasilenko deleted the NAS-132671 branch December 4, 2024 06:16
@bugclerk
Copy link
Contributor

bugclerk commented Dec 4, 2024

This PR has been merged and conversations have been locked.
If you would like to discuss more about this issue please use our forums or raise a Jira ticket.

@truenas truenas locked as resolved and limited conversation to collaborators Dec 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants